From: David Miller <davem@redhat.com>
To: doshir@vmware.com
Cc: netdev@vger.kernel.org, ntanaka@vmware.com, skhare@vmware.com,
pv-drivers@vmware.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3
Date: Fri, 16 Mar 2018 10:53:39 -0400 (EDT) [thread overview]
Message-ID: <20180316.105339.409351441331109496.davem@redhat.com> (raw)
In-Reply-To: <20180313194008.12852-1-doshir@vmware.com>
From: Ronak Doshi <doshir@vmware.com>
Date: Tue, 13 Mar 2018 12:40:08 -0700
> @@ -977,6 +977,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
> {
> int ret;
> u32 count;
> + int numPkts;
> + int localTxNumDeferred;
> unsigned long flags;
> struct vmxnet3_tx_ctx ctx;
> union Vmxnet3_GenericDesc *gdesc;
Please use local variable names with all lowercase letters.
prev parent reply other threads:[~2018-03-16 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 19:40 Ronak Doshi
2018-03-16 14:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316.105339.409351441331109496.davem@redhat.com \
--to=davem@redhat.com \
--cc=doshir@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ntanaka@vmware.com \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®