From: David Miller <davem@davemloft.net>
To: doshir@vmware.com
Cc: netdev@vger.kernel.org, rachel_lunnon@stormagic.com,
skhare@vmware.com, pv-drivers@vmware.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net 2/2] vmxnet3: use correct flag to indicate LRO feature
Date: Sat, 17 Mar 2018 20:05:13 -0400 (EDT) [thread overview]
Message-ID: <20180317.200513.1916546646223366804.davem@davemloft.net> (raw)
In-Reply-To: <20180316214919.20716-1-doshir@vmware.com>
From: Ronak Doshi <doshir@vmware.com>
Date: Fri, 16 Mar 2018 14:49:19 -0700
> 'Commit 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2
> (fwd)")' introduced a flag "lro" in structure vmxnet3_adapter which is
> used to indicate whether LRO is enabled or not. However, the patch
> did not set the flag and hence it was never exercised.
>
> So, when LRO is enabled, it resulted in poor TCP performance due to
> delayed acks. This issue is seen with packets which are larger than
> the mss getting a delayed ack rather than an immediate ack, thus
> resulting in high latency.
>
> This patch removes the lro flag and directly uses device features
> against NETIF_F_LRO to check if lro is enabled.
>
> Fixes: 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")
> Reported-by: Rachel Lunnon <rachel_lunnon@stormagic.com>
> Signed-off-by: Ronak Doshi <doshir@vmware.com>
> Acked-by: Shrikrishna Khare <skhare@vmware.com>
Applied.
prev parent reply other threads:[~2018-03-18 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 21:49 Ronak Doshi
2018-03-18 0:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317.200513.1916546646223366804.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rachel_lunnon@stormagic.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®