mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: mark.rutland@arm.com, heiko@sntech.de, w.egorov@phytec.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: dt-bindings: Add PMIC reset property
Date: Sun, 18 Mar 2018 07:52:07 -0500	[thread overview]
Message-ID: <20180318125207.5dotrxc37owbeyyb@rob-hp-laptop> (raw)
In-Reply-To: <1521111530-39920-1-git-send-email-d.schultz@phytec.de>

On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote:
> Add documentation about a new rk808 devicetree property, which can
> enable resets by the PMIC.

The subject needs to be more specific that this is for Rockchip PMIC.

> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
> index 91b6522..fa1a30f 100644
> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
> @@ -20,6 +20,8 @@ Optional properties:
>    default output clock name
>  - rockchip,system-power-controller: Telling whether or not this pmic is controlling
>    the system power.
> +- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
> +  the system reset.

Would you ever really have power and reset controlled by different 
things? IOW, why do we need 2 properties?

Rob

  reply	other threads:[~2018-03-18 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 10:58 Daniel Schultz
2018-03-18 12:52 ` Rob Herring [this message]
2018-03-29 14:46   ` Daniel Schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180318125207.5dotrxc37owbeyyb@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=d.schultz@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®