From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3205673-1521475354-2-17701143998122738001 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1521475353; b=IDypdOOuTO9J6gBar6F7EtPOCxt7rWB984b7II/GZh9Yigc ZzBGI8YzG34LA5UkWS7TDafsQlJxnJiyxAKHKsseAfarsLjcuB53cpZ49FD85CP6 C2QDo1XUCl2xEXAdTXxSt+NJGLdeBrNrK+932ARNvckvOGu37bQWpXTYHbMC8mD3 dewvUq5wyEH0ryz6CTW++CbdajUJ0MXs+JwkvSBmQXq0gaF3KNDvPfK0jzIqIdgp 3ThZMIdjOEgzPexuNjPBULwnxyAw5DaFlGjUHtAHX5UWhTKvqrY7cp2+4NpqoNjw wPrNYAo3yw0dmlWSOXRRe+nXWmf5ZQdc8HmWBhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1521475353; bh=EiC3T2 3nzySe0zfndSn0/LlrjJW3BXFb7zae9eYJKNE=; b=ZsUoghNmcXY9nTvaiS7o09 eYE7x/YZ5Lici+7dF8Nqc3J3LTQgEuBVFBjjI9OdjkMEyLdRzHrzpoJdE4XFJqxK 75yLh1EhipbF//eQ7+wbT9W3sh3mfxu4HIqKCrdcDgF2wgERAsdTGJFGd3QPtynL oHet6YfceQf4Mw9LruTACgHH+SEigwY2b+Pblb7ASsqHqEipRZqOuHSrWT82HKKY cywMLLVOi7Z9SI+9J7x87psV7oSeY4OsoAdEFwJ3HxgOSDvyEkaVVJaB2LrKnU4o G/Sh59FzojGgma4Jze2lmiraC2xealYYg0hPU1JxPi8m8LkVLtFTha43i85pKnIw == ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Spdm0D5y x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0 spamcause=gggruggvucftvghtrhhoucdtuddrgedtgedrudefgdekvdculddtuddrgedtfedrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhtfffkfhgjihgtgfggshhpjeesthhqredttddtudenucfhrhhomhepufgrshhhrgcunfgvvhhinhcuoeetlhgvgigrnhguvghrrdfnvghvihhnsehmihgtrhhoshhofhhtrdgtohhmqeenucfkphepvddtledrudefvddrudektddrieejpdehvddrudeikedrheegrddvhedvpdhfvgektdemmeefugelsgemjeelvgejmeelgegvsgemheguiedvnecurfgrrhgrmhepihhnvghtpedvtdelrddufedvrddukedtrdeijedphhgvlhhopehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhmrghilhhfrhhomhepoehsthgrsghlvgdqohifnhgvrhesvhhgvghrrdhkvghrnhgvlhdrohhrghequceuqfffjgepkeeukffvoffkoffgucfukfgkgfepjeefkeegnecuvehluhhsthgvrhfuihiivgepudehge; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Spdm0D5y x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0 spamcause=gggruggvucftvghtrhhoucdtuddrgedtgedrudefgdekvdculddtuddrgedtfedrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhtfffkfhgjihgtgfggshhpjeesthhqredttddtudenucfhrhhomhepufgrshhhrgcunfgvvhhinhcuoeetlhgvgigrnhguvghrrdfnvghvihhnsehmihgtrhhoshhofhhtrdgtohhmqeenucfkphepvddtledrudefvddrudektddrieejpdehvddrudeikedrheegrddvhedvpdhfvgektdemmeefugelsgemjeelvgejmeelgegvsgemheguiedvnecurfgrrhgrmhepihhnvghtpedvtdelrddufedvrddukedtrdeijedphhgvlhhopehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhmrghilhhfrhhomhepoehsthgrsghlvgdqohifnhgvrhesvhhgvghrrdhkvghrnhgvlhdrohhrghequceuqfffjgepkeeukffvoffkoffgucfukfgkgfepjeefkeegnecuvehluhhsthgvrhfuihiivgepudehge; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965440AbeCSQCR (ORCPT ); Mon, 19 Mar 2018 12:02:17 -0400 Received: from mail-co1nam03on0123.outbound.protection.outlook.com ([104.47.40.123]:22550 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965420AbeCSQCM (ORCPT ); Mon, 19 Mar 2018 12:02:12 -0400 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Colin Ian King , Kalle Valo , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 150/281] wl1251: check return from call to wl1251_acx_arp_ip_filter Thread-Topic: [PATCH AUTOSEL for 4.9 150/281] wl1251: check return from call to wl1251_acx_arp_ip_filter Thread-Index: AQHTv5tzvAAX1XaILUmxJnQAbS0k4g== Date: Mon, 19 Mar 2018 16:00:50 +0000 Message-ID: <20180319155742.13731-150-alexander.levin@microsoft.com> References: <20180319155742.13731-1-alexander.levin@microsoft.com> In-Reply-To: <20180319155742.13731-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0933;7:BRQ6n4CiYexSdtHEluGtOemGcKYn103HSGt9RbxBpjEY5+UNJYr88b4JR2ZxSGRMpsN0m5DvnmpJhfFqLKGTy7feBNGRtYV7Xmg4t+mT5Fp78x/k2pUH49JSHZHiauoGW45RJ+uj+rbIuJl3tfYFJWVd0EoH0XTL+SUWOnp0RxhdESQI7i2HuQFlTa1PmNb4Z8HLfVr1fo3l3j6XVj13tJkbnc3LbA74RBV13FanBzuKGWVwjj6l6lW8FHk8Bf6r;20:WG8JOgvXZFsyLUaUC9wHRy5KSpAX8TMQpMYpVaOxgxsyXjJXl4fVNIf4eIBsuPrXSFtJrQ/QtO280dNw60xCyouBLXtU16mVsmxRfhGsrybh4ietDS0HycEO92pABui/8h6ue6noAMG9lIWngjy4uuyDoKzJ5KVl74+IS1LNxL4= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 373cce8f-a5d4-4883-72a3-08d58db2c0af x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0933; x-ms-traffictypediagnostic: DM5PR2101MB0933: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501300)(52105095)(6055026)(61426038)(61427038)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:DM5PR2101MB0933;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0933; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(396003)(39380400002)(366004)(346002)(376002)(199004)(189003)(2501003)(72206003)(1076002)(66066001)(10290500003)(99286004)(10090500001)(7736002)(14454004)(6116002)(5660300001)(2906002)(97736004)(6666003)(6346003)(15760500003)(102836004)(22452003)(86612001)(3660700001)(186003)(2900100001)(25786009)(478600001)(5250100002)(26005)(6486002)(6436002)(81156014)(81166006)(36756003)(4326008)(86362001)(76176011)(6512007)(8936002)(106356001)(3846002)(53936002)(105586002)(3280700002)(305945005)(68736007)(110136005)(2950100002)(54906003)(8676002)(107886003)(316002)(6506007)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0933;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: zFXGOyHi9qZx6cigFEQV9PrPYG4LcV8cKND6HfNt9c66TJMWoaiLrwaoN0AB8MYn+iYMl0xv10XyI30u+7HW/cPwK/PDDwK47UixTD+QJhNYYKL1Yv0O96iSvf39csTi8615P4F9hatt3myFYBNM6dLspGjnvjlLgahl0KnFRMnVjA7DWqgOGDigzu18/AFU2ZZkVJuLPBFVL6OOz0cFox46/GjHikB3CoAZhfCtk9GQzIlU7ApG47OSDJQM1rmGMl2ujFlSLukd2x0zbG5kxVHQPKeeLifmR3xW8cwnPesdzWnMRHrZ3Xtzvhi4HRnklNZJ9w3FXeeTeV3MLtnMVg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 373cce8f-a5d4-4883-72a3-08d58db2c0af X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 16:00:50.7410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0933 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Colin Ian King [ Upstream commit ac1181c60822292176ab96912208ec9f9819faf8 ] Currently the less than zero error check on ret is incorrect as it is checking a far earlier ret assignment rather than the return from the call to wl1251_acx_arp_ip_filter. Fix this by adding in the missing assginment. Detected by CoverityScan, CID#1164835 ("Logically dead code") Fixes: 204cc5c44fb6 ("wl1251: implement hardware ARP filtering") Signed-off-by: Colin Ian King Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ti/wl1251/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/t= i/wl1251/main.c index 1c539c83e8cf..5e41bf04ef61 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -1200,8 +1200,7 @@ static void wl1251_op_bss_info_changed(struct ieee802= 11_hw *hw, WARN_ON(wl->bss_type !=3D BSS_TYPE_STA_BSS); =20 enable =3D bss_conf->arp_addr_cnt =3D=3D 1 && bss_conf->assoc; - wl1251_acx_arp_ip_filter(wl, enable, addr); - + ret =3D wl1251_acx_arp_ip_filter(wl, enable, addr); if (ret < 0) goto out_sleep; } --=20 2.14.1