From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbeCTFxH (ORCPT ); Tue, 20 Mar 2018 01:53:07 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:50053 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbeCTFxG (ORCPT ); Tue, 20 Mar 2018 01:53:06 -0400 Date: Tue, 20 Mar 2018 13:52:54 +0800 From: joeyli To: "Rafael J. Wysocki" Cc: "Lee, Chun-Yi" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Len Brown Subject: Re: [PATCH] ACPI / scan: Send the change uevent with offine environmental data Message-ID: <20180320055254.GJ15088@linux-l9pv.suse> References: <20180302063508.15818-1-jlee@suse.com> <12390857.1FYhrZHzGj@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12390857.1FYhrZHzGj@aspire.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Mon, Mar 19, 2018 at 11:02:32AM +0100, Rafael J. Wysocki wrote: > On Friday, March 2, 2018 7:35:08 AM CET Lee, Chun-Yi wrote: > > In current design of ACPI container offline, Kernel emits > > KOBJ_CHANGE uevent to user space to indidate that the ejection of > > the container was triggered by platform. (caa73ea15 patch) > > > > A pure KOBJ_CHANGE uevent is not enough for user space to identify > > the purpose. For example, a "udevadm trigger" command can also > > be used to emit change event to all udev rules. A udev rule can not > > identify that the event is from kernel for offline or from udevadm > > for other purpose. Then the offline action in udev rule may also be > > triggered by udevadm tool. > > > > So, similar to the change uevent of dock, kernel sends the > > KOBJ_CHANGE uevent with a offline environmental data to indicate > > purpose. It's useful by udev rule for using ENV{EVENT} filter. > > > > Cc: Michal Hocko > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Signed-off-by: "Lee, Chun-Yi" > > --- > > drivers/acpi/scan.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index 8e63d93..f6dca9b 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -116,6 +116,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent) > > { > > struct acpi_device_physical_node *pn; > > bool offline = true; > > + static const char *envp[] = { "EVENT=offline", NULL }; > > > > /* > > * acpi_container_offline() calls this for all of the container's > > @@ -126,7 +127,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent) > > list_for_each_entry(pn, &adev->physical_node_list, node) > > if (device_supports_offline(pn->dev) && !pn->dev->offline) { > > if (uevent) > > - kobject_uevent(&pn->dev->kobj, KOBJ_CHANGE); > > + kobject_uevent_env(&pn->dev->kobj, KOBJ_CHANGE, envp); > > > > offline = false; > > break; > > > > This causes build issues when applied, please fix. > I just sent the v2 patch. Thanks for your review! Joey Lee