From: Peter Zijlstra <peterz@infradead.org>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 1/2] sched/debug: fix per-task line continuation for console
Date: Tue, 20 Mar 2018 09:08:52 +0100 [thread overview]
Message-ID: <20180320080852.GM4043@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <6b826ab1-c6a4-244e-ace6-d735b415a268@redhat.com>
On Mon, Mar 19, 2018 at 04:43:28PM -0400, Joe Lawrence wrote:
> On 03/19/2018 04:17 PM, Peter Zijlstra wrote:
> I don't have the commit offhand that changed the printk behavior, but
> from observation:
4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
and thereabout I think.
> > Does pr_cont("\n") DTRT? it seems like something weird.
> >
>
> Yeah, pr_cont() is kind of a hack. It will terminate a line if that's
> the first newline, but as demonstrated above, I don't think it likes
> extra newline chars.
Fair enough I suppose, just a bit weird.
> A better fix would be to marshal the text into temp buffer then dump it
> out. Dunno if you prefer that kind of churn for these stats.
Yeah, not worth it, simple is better here.
next prev parent reply other threads:[~2018-03-20 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 18:35 [PATCH 0/2] small scheduler debug stat fixups Joe Lawrence
2018-03-19 18:35 ` [PATCH 1/2] sched/debug: fix per-task line continuation for console Joe Lawrence
2018-03-19 20:17 ` Peter Zijlstra
2018-03-19 20:43 ` Joe Lawrence
2018-03-20 8:08 ` Peter Zijlstra [this message]
2018-03-20 11:18 ` [tip:sched/urgent] sched/debug: Fix per-task line continuation for console output tip-bot for Joe Lawrence
2018-03-19 18:35 ` [PATCH 2/2] sched/debug: adjust newlines for better alignment Joe Lawrence
2018-03-20 11:19 ` [tip:sched/urgent] sched/debug: Adjust " tip-bot for Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320080852.GM4043@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome