From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] aio: add delayed cancel support
Date: Wed, 21 Mar 2018 10:18:42 +0100 [thread overview]
Message-ID: <20180321091842.GO14085@kroah.com> (raw)
In-Reply-To: <20180321073232.13366-8-hch@lst.de>
On Wed, Mar 21, 2018 at 08:32:30AM +0100, Christoph Hellwig wrote:
> The upcoming aio poll support would like to be able to complete the
> iocb inline from the cancellation context, but that would cause
> a lock order reversal. Add support for optionally moving the cancelation
> outside the context lock to avoid this reversal.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> fs/aio.c | 49 ++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 38 insertions(+), 11 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 0b6394b4e528..9d7d6e4cde87 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -170,6 +170,10 @@ struct aio_kiocb {
> struct list_head ki_list; /* the aio core uses this
> * for cancellation */
>
> + unsigned int flags; /* protected by ctx->ctx_lock */
> +#define AIO_IOCB_DELAYED_CANCEL (1 << 0)
> +#define AIO_IOCB_CANCELLED (1 << 1)
BIT(0) and BIT(1)?
Anyway, not a big deal...
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2018-03-21 9:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 7:32 io_pgetevents & aio fsync Christoph Hellwig
2018-03-21 7:32 ` [PATCH 1/9] aio: don't print the page size at boot time Christoph Hellwig
2018-03-21 9:12 ` Greg KH
2018-03-21 7:32 ` [PATCH 2/9] aio: remove an outdated comment in aio_complete Christoph Hellwig
2018-03-21 9:14 ` Greg KH
2018-03-21 9:17 ` Christoph Hellwig
2018-03-21 7:32 ` [PATCH 3/9] aio: refactor read/write iocb setup Christoph Hellwig
2018-03-21 9:15 ` Greg KH
2018-03-21 7:32 ` [PATCH 4/9] aio: sanitize ki_list handling Christoph Hellwig
2018-03-21 9:16 ` Greg KH
2018-03-22 15:24 ` Al Viro
2018-03-22 17:04 ` Christoph Hellwig
2018-03-21 7:32 ` [PATCH 5/9] aio: simplify cancellation Christoph Hellwig
2018-03-21 9:17 ` Greg KH
2018-03-21 16:23 ` Darrick J. Wong
2018-03-21 7:32 ` [PATCH 6/9] aio: delete iocbs from the active_reqs list in kiocb_cancel Christoph Hellwig
2018-03-21 9:17 ` Greg KH
2018-03-21 16:23 ` Darrick J. Wong
2018-03-21 7:32 ` [PATCH 7/9] aio: add delayed cancel support Christoph Hellwig
2018-03-21 9:18 ` Greg KH [this message]
2018-03-21 16:23 ` Darrick J. Wong
2018-03-22 16:33 ` Al Viro
2018-03-21 7:32 ` [PATCH 8/9] aio: implement io_pgetevents Christoph Hellwig
2018-03-21 9:24 ` Greg KH
2018-03-21 9:29 ` Christoph Hellwig
2018-03-21 14:39 ` Greg KH
2018-03-21 16:26 ` Darrick J. Wong
2018-03-21 7:32 ` [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC Christoph Hellwig
2018-03-21 9:27 ` Greg KH
2018-03-21 9:30 ` Christoph Hellwig
2018-03-21 16:26 ` Darrick J. Wong
2018-03-22 16:36 ` io_pgetevents & aio fsync Al Viro
2018-03-22 16:36 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321091842.GO14085@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avi@scylladb.com \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome