From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pratik Jain <pratik.jain0509@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, arnaud.patard@rtp-net.org
Subject: Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function
Date: Wed, 21 Mar 2018 12:24:58 +0300 [thread overview]
Message-ID: <20180321092458.76v5jujepp2inmov@mwanda> (raw)
In-Reply-To: <20180320140232.26096-1-pratik.jain0509@gmail.com>
On Tue, Mar 20, 2018 at 07:32:32PM +0530, Pratik Jain wrote:
> Refactored the function `XGIfb_search_refresh_rate` by removing a level
> of `if...else` block nesting. Removed unnecessary parantheses.
>
> Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
> ---
> drivers/staging/xgifb/XGI_main_26.c | 59 +++++++++++++++++++------------------
> 1 file changed, 30 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 10107de0119a..aee969aab681 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -544,41 +544,42 @@ static u8 XGIfb_search_refresh_rate(struct xgifb_video_info *xgifb_info,
> yres = XGIbios_mode[xgifb_info->mode_idx].yres;
>
> xgifb_info->rate_idx = 0;
> - while ((XGIfb_vrate[i].idx != 0) && (XGIfb_vrate[i].xres <= xres)) {
> - if ((XGIfb_vrate[i].xres == xres) &&
> - (XGIfb_vrate[i].yres == yres)) {
> - if (XGIfb_vrate[i].refresh == rate) {
> +
> + while (XGIfb_vrate[i].idx != 0 && XGIfb_vrate[i].xres <= xres) {
> + /* Skip values with xres or yres less than specified */
> + if ((XGIfb_vrate[i].yres != yres) ||
> + (XGIfb_vrate[i].xres < xres)) {
Both < and != are equivalent, but to me != feels more obvious. With !=
the opposite of that is *always* == so that's obvious just by looking at
it. But with < you have to look at the lines before so you have to
remember more stuff to understand the code.
The other thing is that != xres matches nicely with != yres. Otherwise
I sort of assume from looking at it that != and < are different things.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-21 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 8:35 Pratik Jain
2018-03-20 11:20 ` Dan Carpenter
2018-03-20 11:41 ` Pratik Jain
2018-03-20 11:54 ` Pratik Jain
2018-03-20 12:03 ` Dan Carpenter
2018-03-20 14:02 ` Pratik Jain
2018-03-21 9:24 ` Dan Carpenter [this message]
2018-03-21 9:50 ` Pratik Jain
2018-03-21 10:05 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2018-03-19 15:56 Pratik Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321092458.76v5jujepp2inmov@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pratik.jain0509@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®