From: NIIBE Yutaka <gniibe@fsij.org>
To: linux-kernel@vger.kernel.org
Cc: NIIBE Yutaka <gniibe@fsij.org>
Subject: [PATCH v2 3/4] signal/x86: Move restore_saved_sigmask().
Date: Thu, 22 Mar 2018 10:44:12 +0900 [thread overview]
Message-ID: <20180322014413.24099-4-gniibe@fsij.org> (raw)
In-Reply-To: <20180322014413.24099-1-gniibe@fsij.org>
Call to restore_saved_sigmask is only needed when it is from a system
call. It is only woken up system call which uses saved_sigmask.
Specifically, they are pselect, ppoll, and epoll_pwait.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
---
arch/x86/kernel/signal.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index e709b54a01b8..9c24df5ca2d4 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -834,13 +834,13 @@ void nosig_restart_syscall(struct pt_regs *regs)
regs->ip -= 2;
break;
}
- }
- /*
- * If there's no signal to deliver, we just put the saved sigmask
- * back.
- */
- restore_saved_sigmask();
+ /*
+ * If there's no signal to deliver, we just put the
+ * saved sigmask back.
+ */
+ restore_saved_sigmask();
+ }
}
void signal_fault(struct pt_regs *regs, void __user *frame, char *where)
--
2.11.0
next prev parent reply other threads:[~2018-03-22 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 1:44 [PATCH v2 0/4] Fix no signal delivery at do_signal NIIBE Yutaka
2018-03-22 1:44 ` [PATCH v2 1/4] signal/x86: Factor out nosig handling NIIBE Yutaka
2018-03-22 1:44 ` [PATCH v2 2/4] signal/x86: do_signal: syscall restart should be done only once NIIBE Yutaka
2018-03-22 1:44 ` NIIBE Yutaka [this message]
2018-03-22 1:44 ` [PATCH v2 4/4] signal/x86: Move nosig handling at the end of exit_to_usermode_loop NIIBE Yutaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322014413.24099-4-gniibe@fsij.org \
--to=gniibe@fsij.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®