From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbeCWNr5 (ORCPT ); Fri, 23 Mar 2018 09:47:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:37880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbeCWNr4 (ORCPT ); Fri, 23 Mar 2018 09:47:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1661A21718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 23 Mar 2018 09:47:53 -0400 From: Steven Rostedt To: Michal Hocko Cc: LKML , linux-mm@kvack.org, Mel Gorman , Vlastimil Babka , Andrew Morton , Linus Torvalds , Alexei Starovoitov Subject: Re: [PATCH] mm, vmscan, tracing: Use pointer to reclaim_stat struct in trace event Message-ID: <20180323094753.760b2c86@gandalf.local.home> In-Reply-To: <20180323134200.GT23100@dhcp22.suse.cz> References: <20180322121003.4177af15@gandalf.local.home> <20180323134200.GT23100@dhcp22.suse.cz> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Mar 2018 14:42:00 +0100 Michal Hocko wrote: > Yes, the number of parameter is large. struct reclaim_stat is an > internal stuff so I didn't want to export it. I do not have strong > objections to add it somewhere tracing can find it though. The one solution is to pull the tracing file include/trace/events/vmscan.h into mm/ and have a local header to store the reclaim_stat structure that both vmscan.h and vmscan.c can reference. I'll make a patch once I hear which way Andrey's patches are going. That way I don't need to do it twice. -- Steve