From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joelaf@google.com>
Subject: Re: rcu: Add might_sleep() check to synchronize_rcu()
Date: Fri, 23 Mar 2018 17:28:43 -0400 [thread overview]
Message-ID: <20180323172843.763579a9@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.21.1803232210110.1481@nanos.tec.linutronix.de>
On Fri, 23 Mar 2018 22:12:24 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> synchronize_rcu() lacks a might_sleep() check which would have caught that
> issue way earlier because it would trigger with the minimal debug options
> enabled.
>
> Add a might_sleep() check to catch such cases.
I'm not against the patch, but really? I would think that
synchronize_rcu() would pretty much always schedule, and scheduling
from atomic would have triggered with minimal debug options enabled.
-- Steve
next prev parent reply other threads:[~2018-03-23 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 21:12 Thomas Gleixner
2018-03-23 21:28 ` Steven Rostedt [this message]
2018-03-23 21:33 ` Thomas Gleixner
2018-03-23 21:40 ` Steven Rostedt
2018-03-23 21:46 ` Thomas Gleixner
2018-03-23 22:57 ` Joel Fernandes
2018-03-24 1:21 ` Steven Rostedt
2018-03-25 18:43 ` Paul E. McKenney
2018-03-25 18:50 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323172843.763579a9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jiangshanlai@gmail.com \
--cc=joelaf@google.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®