From: kbuild test robot <lkp@intel.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Heiko Stuebner <heiko@sntech.de>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Amelie Delaunay <amelie.delaunay@st.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: dwc2: dwc2_vbus_supply_init: fix error check
Date: Sat, 24 Mar 2018 08:24:57 +0800 [thread overview]
Message-ID: <201803240827.nmiIDaqS%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180322131451.12631-1-tomeu.vizoso@collabora.com>
Hi Tomeu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on next-20180323]
[cannot apply to v4.16-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tomeu-Vizoso/usb-dwc2-dwc2_vbus_supply_init-fix-error-check/20180324-063752
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
coccinelle warnings: (new ones prefixed by >>)
>> drivers/usb/dwc2/hcd.c:367:9-16: ERROR: PTR_ERR applied after initialization to constant on line 366
vim +367 drivers/usb/dwc2/hcd.c
358
359 static int dwc2_vbus_supply_init(struct dwc2_hsotg *hsotg)
360 {
361 hsotg->vbus_supply = devm_regulator_get_optional(hsotg->dev, "vbus");
362 if (PTR_ERR(hsotg->vbus_supply) == -ENODEV) {
363 hsotg->vbus_supply = NULL;
364 return 0;
365 } else if (IS_ERR(hsotg->vbus_supply)) {
> 366 hsotg->vbus_supply = NULL;
> 367 return PTR_ERR(hsotg->vbus_supply);
368 }
369
370 return regulator_enable(hsotg->vbus_supply);
371 }
372
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-03-24 0:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 9:39 [PATCH] " Tomeu Vizoso
2018-03-22 11:39 ` Heiko Stübner
2018-03-22 11:41 ` Heiko Stübner
2018-03-22 12:21 ` Amelie DELAUNAY
2018-03-22 13:06 ` [PATCH v2] " Tomeu Vizoso
2018-03-22 13:14 ` [PATCH v3] " Tomeu Vizoso
2018-03-22 13:26 ` Heiko Stübner
2018-03-22 13:34 ` Tomeu Vizoso
2018-03-24 0:24 ` kbuild test robot [this message]
2018-03-26 9:00 ` [PATCH v4] " Tomeu Vizoso
2018-03-26 10:56 ` Amelie DELAUNAY
2018-03-26 11:51 ` Heiko Stübner
2018-04-04 13:33 ` Tomeu Vizoso
2018-04-05 7:54 ` Minas Harutyunyan
2018-04-05 8:10 ` Tomeu Vizoso
2018-04-05 9:02 ` Grigor Tovmasyan
2018-04-05 8:58 ` Grigor Tovmasyan
2018-04-05 9:51 ` Minas Harutyunyan
2018-04-10 12:28 ` Heiko Stuebner
2018-04-10 13:52 ` Minas Harutyunyan
2018-04-10 15:37 ` Heiko Stübner
2018-04-11 6:50 ` Minas Harutyunyan
2018-04-23 13:24 ` Tomeu Vizoso
2018-04-24 8:58 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803240827.nmiIDaqS%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=amelie.delaunay@st.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hminas@synopsys.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®