From: Benson Leung <bleung@google.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Benson Leung <bleung@chromium.org>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, achant@google.com
Subject: Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.
Date: Sat, 24 Mar 2018 10:43:11 -0700 [thread overview]
Message-ID: <20180324174311.GA12922@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1803241155560.30456-100000@netrider.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Sat, Mar 24, 2018 at 12:06:20PM -0400, Alan Stern wrote:
> > + dev_info(&udev->dev,
> > + "New USB device found, idVendor=%04x, idProduct=%04x, bcdDevice=%2x.%02x\n",
> > + le16_to_cpu(udev->descriptor.idVendor),
>
> Unnecessary and incorrect whitespace changes.
Thanks Alan. Fixed in v3.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-24 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 0:33 [PATCH] " Benson Leung
2018-03-24 0:48 ` Andrew Chant
2018-03-24 1:08 ` Andrew Chant
2018-03-24 1:34 ` Benson Leung
2018-03-24 1:31 ` [PATCH v2] " Benson Leung
2018-03-24 16:06 ` Alan Stern
2018-03-24 17:43 ` Benson Leung [this message]
2018-03-24 17:40 ` [PATCH v3] " Benson Leung
2018-03-26 18:27 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324174311.GA12922@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=achant@google.com \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome