From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbeCZK4m (ORCPT ); Mon, 26 Mar 2018 06:56:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:33874 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840AbeCZK4k (ORCPT ); Mon, 26 Mar 2018 06:56:40 -0400 Date: Mon, 26 Mar 2018 12:56:38 +0200 From: Hannes Reinecke To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH] scsi: don't look for NULL devices handlers by name Message-ID: <20180326125638.2510d7dd@pentland.suse.de> In-Reply-To: <20180323133705.14556-1-jthumshirn@suse.de> References: <20180323133705.14556-1-jthumshirn@suse.de> Organization: SUSE Linux GmbH X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Mar 2018 14:37:05 +0100 Johannes Thumshirn wrote: > Currently scsi_dh_lookup() doesn't check for NULL as a device > name. This combined with nvme over dm-mapth results in the following > messages emitted by device-mapper: > > device-mapper: multipath: Could not failover device 259:67: Handler > scsi_dh_(null) error 14. > > Let scsi_dh_lookup() fail fast on NULL names. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/scsi_dh.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c > index b88b5dbbc444..188f30572aa1 100644 > --- a/drivers/scsi/scsi_dh.c > +++ b/drivers/scsi/scsi_dh.c > @@ -112,6 +112,9 @@ static struct scsi_device_handler > *scsi_dh_lookup(const char *name) { > struct scsi_device_handler *dh; > > + if (!name || strlen(name) == 0) > + return NULL; > + > dh = __scsi_dh_lookup(name); > if (!dh) { > request_module("scsi_dh_%s", name); Reviewed-by: Hannes Reinecke Cheers, Hannes