From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbeCZTOB (ORCPT ); Mon, 26 Mar 2018 15:14:01 -0400 Received: from mga07.intel.com ([134.134.136.100]:11681 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbeCZTN7 (ORCPT ); Mon, 26 Mar 2018 15:13:59 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,365,1517904000"; d="scan'208";a="45450249" Date: Tue, 27 Mar 2018 03:13:28 +0800 From: kbuild test robot To: Alexandre Belloni Cc: kbuild-all@01.org, "David S . Miller" , Allan Nielsen , razvan.stefanescu@nxp.com, po.liu@nxp.com, Thomas Petazzoni , Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Alexandre Belloni Subject: Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support Message-ID: <201803270232.QvYkUzOs%fengguang.wu@intel.com> References: <20180323201117.8416-6-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180323201117.8416-6-alexandre.belloni@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180323] [also build test WARNING on v4.16-rc7] [cannot apply to net-next/master net/master robh/for-next v4.16-rc6 v4.16-rc5 v4.16-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/Microsemi-Ocelot-switch-support/20180325-234932 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/mscc/ocelot.c:395:17: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int [unsigned] [usertype] val @@ got ed int [unsigned] [usertype] val @@ drivers/net/ethernet/mscc/ocelot.c:395:17: expected unsigned int [unsigned] [usertype] val drivers/net/ethernet/mscc/ocelot.c:395:17: got restricted __le32 [usertype] -- >> drivers/net/ethernet/mscc/ocelot_io.c:110:24: sparse: incorrect type in return expression (different address spaces) @@ expected struct regmap * @@ got void [noderef] *[assigned] regs -- >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:41:26: sparse: cast to restricted __be32 >> drivers/net/ethernet/mscc/ocelot_board.c:142:34: sparse: cast to restricted __le32 vim +395 drivers/net/ethernet/mscc/ocelot.c 367 368 static int ocelot_port_xmit(struct sk_buff *skb, struct net_device *dev) 369 { 370 struct ocelot_port *port = netdev_priv(dev); 371 struct ocelot *ocelot = port->ocelot; 372 u32 val, ifh[IFH_LEN]; 373 struct frame_info info = {}; 374 u8 grp = 0; /* Send everything on CPU group 0 */ 375 int i, count, last; 376 377 val = ocelot_read(ocelot, QS_INJ_STATUS); 378 if (!(val & QS_INJ_STATUS_FIFO_RDY(BIT(grp))) || 379 (val & QS_INJ_STATUS_WMARK_REACHED(BIT(grp)))) 380 return NETDEV_TX_BUSY; 381 382 ocelot_write_rix(ocelot, QS_INJ_CTRL_GAP_SIZE(1) | 383 QS_INJ_CTRL_SOF, QS_INJ_CTRL, grp); 384 385 info.port = BIT(port->chip_port); 386 info.cpuq = 0xff; 387 ocelot_gen_ifh(ifh, &info); 388 389 for (i = 0; i < IFH_LEN; i++) 390 ocelot_write_rix(ocelot, ifh[i], QS_INJ_WR, grp); 391 392 count = (skb->len + 3) / 4; 393 last = skb->len % 4; 394 for (i = 0; i < count; i++) { > 395 ocelot_write_rix(ocelot, cpu_to_le32(((u32 *)skb->data)[i]), 396 QS_INJ_WR, grp); 397 } 398 399 /* Add padding */ 400 while (i < (OCELOT_BUFFER_CELL_SZ / 4)) { 401 ocelot_write_rix(ocelot, 0, QS_INJ_WR, grp); 402 i++; 403 } 404 405 /* Indicate EOF and valid bytes in last word */ 406 ocelot_write_rix(ocelot, QS_INJ_CTRL_GAP_SIZE(1) | 407 QS_INJ_CTRL_VLD_BYTES(skb->len < OCELOT_BUFFER_CELL_SZ ? 0 : last) | 408 QS_INJ_CTRL_EOF, 409 QS_INJ_CTRL, grp); 410 411 /* Add dummy CRC */ 412 ocelot_write_rix(ocelot, 0, QS_INJ_WR, grp); 413 skb_tx_timestamp(skb); 414 415 dev->stats.tx_packets++; 416 dev->stats.tx_bytes += skb->len; 417 dev_kfree_skb_any(skb); 418 419 return NETDEV_TX_OK; 420 } 421 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation