mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] locking/debug: Add a master lock debugging switch
Date: Tue, 27 Mar 2018 16:13:21 -0700	[thread overview]
Message-ID: <20180327231321.4on2kczby5ejqglt@linux-n805> (raw)
In-Reply-To: <1522186690-10526-3-git-send-email-longman@redhat.com>

On Tue, 27 Mar 2018, Waiman Long wrote:

>Add a new master LOCK_DEBUGGING Kconfig option to turn on all the lock
>debugging options except the selftests and the torture tests.

For what purpose?

I'm not sure we want yet another config debug option. These are all expert
level configuration and honestly I would rather such users _think_ about
what options they are enabling instead of giving them a large hammer.

If enough load, this can also make boxes completely locked up for any sort of
testing/debugging. I vote no.

Also, CI efforts such 0-day already have the necessary scripting to cover the
debug options that make sense.

Thanks,
Davidlohr

  reply	other threads:[~2018-03-27 23:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 21:38 [PATCH v3 0/2] locking/debug: Add DEBUG_RWSEMS & LOCK_DEBUGGING Waiman Long
2018-03-27 21:38 ` [PATCH v3 1/2] locking/rwsem: Add DEBUG_RWSEMS to look for lock/unlock mismatches Waiman Long
2018-03-27 21:38 ` [PATCH v3 2/2] locking/debug: Add a master lock debugging switch Waiman Long
2018-03-27 23:13   ` Davidlohr Bueso [this message]
2018-03-28 13:05     ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327231321.4on2kczby5ejqglt@linux-n805 \
    --to=dave@stgolabs.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®