From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Scott Branden <scott.branden@broadcom.com>,
Abhishek Shah <abhishek.shah@broadcom.com>,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org (open list),
bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH net-next 2/2] net: bgmac: Mask interrupts during probe
Date: Tue, 27 Mar 2018 16:20:02 -0700 [thread overview]
Message-ID: <20180327232002.29399-3-f.fainelli@gmail.com> (raw)
In-Reply-To: <20180327232002.29399-1-f.fainelli@gmail.com>
We can have interrupts left enabled form e.g: the bootloader which used
the network device for network boot. Make sure we have those disabled as
early as possible to avoid spurious interrupts.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bgmac.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 46d7b8068425..2326cc219c46 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1492,6 +1492,8 @@ int bgmac_enet_probe(struct bgmac *bgmac)
struct net_device *net_dev = bgmac->net_dev;
int err;
+ bgmac_chip_intrs_off(bgmac);
+
net_dev->irq = bgmac->irq;
SET_NETDEV_DEV(net_dev, bgmac->dev);
dev_set_drvdata(bgmac->dev, bgmac);
--
2.14.1
next prev parent reply other threads:[~2018-03-27 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 23:20 [PATCH net-next 0/2] net: bgmac: Couple of small bgmac changes Florian Fainelli
2018-03-27 23:20 ` [PATCH net-next 1/2] net: bgmac: Use interface name to request interrupt Florian Fainelli
2018-03-27 23:20 ` Florian Fainelli [this message]
2018-03-29 16:06 ` [PATCH net-next 0/2] net: bgmac: Couple of small bgmac changes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327232002.29399-3-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=abhishek.shah@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome