From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbeC1CJF (ORCPT ); Tue, 27 Mar 2018 22:09:05 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:57466 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492AbeC1CJD (ORCPT ); Tue, 27 Mar 2018 22:09:03 -0400 Date: Wed, 28 Mar 2018 10:08:45 +0800 From: Mark Brown To: David Collins Cc: Doug Anderson , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , sboyd@kernel.org, ilina@codeaurora.org Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180328020845.GB29099@sirena.org.uk> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <184378e4-caf8-6ce3-e089-3690588fcb28@codeaurora.org> <20180327115606.GC29239@sirena.org.uk> <172d1da4-bde0-1f0c-b907-5582c31c8156@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <172d1da4-bde0-1f0c-b907-5582c31c8156@codeaurora.org> X-Cookie: Turn the other cheek. User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 27, 2018 at 04:38:07PM -0700, David Collins wrote: > On 03/27/2018 04:56 AM, Mark Brown wrote: > > I didn't spot this in the code but something called "device tree mode" > > sounds like it's going to be awfully confusing... > As I explained in the earlier email, it makes the device tree > configurations much simpler and less confusing/error prone. I'd like to > keep this concept around unless their are strong objections. Like I say I didn't spot this in the code, I did give it a brief once over but as Doug had spotted such extensive problems I was expecting a resend. It *is* setting off big alarm bells though, in general if your individual driver is doing something weird to make life easier that's a sign that it's doing things at the wrong level. --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlq6+SwACgkQJNaLcl1U h9C+SAf/Xk5fE40iWdnaUAqxbdfK4umBb0ItVeFUEAEC5DU7mZmPPr9R+Ziqog80 V7Kjb7qmjamPSeATF/ShzlEusjGwihXp1V8/M3Tov5Tc9pTAgFWU/2FrasWGAmXs upINCPMZDk7qmBfqb46sFYZd5FL8HSjr0cI4m7xWZKBQMIjRkWrt7S32USdKikiI 6m8fXobyddNS4D9d0OfySaE7/IeOE6KqkcNvWARGrPUdnB5SjbxK5hSLIIauXE2D kNwPWhvGCwLABbmn97g58d2il3JtKCqS9Casek28B568yp+VWYkWRzrhdlQVjv3y z1S5aAniKXr6/AZdi2ti3eBV+V5Qpg== =rd+x -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--