From: Chris Coffey <cmc@babblebit.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
NeilBrown <neil@brown.name>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Chris Coffey <cmc@babblebit.net>
Subject: [PATCH] staging: mt7621-eth: Fix sparse warning in ethtool.c
Date: Wed, 28 Mar 2018 22:18:48 +0100 [thread overview]
Message-ID: <20180328211848.11085-1-cmc@babblebit.net> (raw)
Include the local ethtool.h header file in mtk_eth_soc.h so
implementation files have centralized access to it.
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off-by: Chris Coffey <cmc@babblebit.net>
---
drivers/staging/mt7621-eth/mtk_eth_soc.c | 1 -
drivers/staging/mt7621-eth/mtk_eth_soc.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c
index cbc7339843..0574e71573 100644
--- a/drivers/staging/mt7621-eth/mtk_eth_soc.c
+++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c
@@ -35,7 +35,6 @@
#include "mtk_eth_soc.h"
#include "mdio.h"
-#include "ethtool.h"
#define MAX_RX_LENGTH 1536
#define MTK_RX_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN)
diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.h b/drivers/staging/mt7621-eth/mtk_eth_soc.h
index 443f88d8af..01deeddfdd 100644
--- a/drivers/staging/mt7621-eth/mtk_eth_soc.h
+++ b/drivers/staging/mt7621-eth/mtk_eth_soc.h
@@ -23,6 +23,7 @@
#include <linux/ethtool.h>
#include <linux/version.h>
#include <linux/atomic.h>
+#include "ethtool.h"
/* these registers have different offsets depending on the SoC. we use a lookup
* table for these
--
2.11.0
next reply other threads:[~2018-03-28 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 21:18 Chris Coffey [this message]
2018-03-29 9:56 ` Greg Kroah-Hartman
2018-03-29 12:47 ` [PATCH v2] " Chris Coffey
2018-04-01 23:34 ` NeilBrown
2018-04-02 3:04 ` Sean Wang
2018-04-02 3:41 ` NeilBrown
2018-04-02 11:41 ` Christian Lütke-Stetzkamp
2018-04-02 22:39 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328211848.11085-1-cmc@babblebit.net \
--to=cmc@babblebit.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome