From: kbuild test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: kbuild-all@01.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: [PATCH v2 1/2] power/hibernate: Make passing hibernate offsets more friendly
Date: Wed, 28 Mar 2018 22:01:49 +0800 [thread overview]
Message-ID: <201803282121.2P3DkXpO%fengguang.wu@intel.com> (raw)
In-Reply-To: <1522184333-27582-1-git-send-email-mario.limonciello@dell.com>
[-- Attachment #1: Type: text/plain, Size: 2636 bytes --]
Hi Mario,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc7 next-20180328]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/power-hibernate-Make-passing-hibernate-offsets-more-friendly/20180328-212230
config: i386-randconfig-x006-201812 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
kernel/power/hibernate.c: In function 'resume_offset_show':
kernel/power/hibernate.c:1067:25: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'sector_t {aka long long unsigned int}' [-Wformat=]
return sprintf(buf, "%lu\n", swsusp_resume_block);
~~^
%llu
kernel/power/hibernate.c: In function 'resume_offset_store':
>> kernel/power/hibernate.c:1074:28: error: passing argument 3 of 'kstrtoul' from incompatible pointer type [-Werror=incompatible-pointer-types]
int rc = kstrtoul(buf, 0, &swsusp_resume_block);
^
In file included from include/linux/list.h:9:0,
from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/swap.h:5,
from include/linux/suspend.h:5,
from kernel/power/hibernate.c:16:
include/linux/kernel.h:332:32: note: expected 'long unsigned int *' but argument is of type 'sector_t * {aka long long unsigned int *}'
static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res)
^~~~~~~~
cc1: some warnings being treated as errors
vim +/kstrtoul +1074 kernel/power/hibernate.c
1063
1064 static ssize_t resume_offset_show(struct kobject *kobj,
1065 struct kobj_attribute *attr, char *buf)
1066 {
> 1067 return sprintf(buf, "%lu\n", swsusp_resume_block);
1068 }
1069
1070 static ssize_t resume_offset_store(struct kobject *kobj,
1071 struct kobj_attribute *attr, const char *buf,
1072 size_t n)
1073 {
> 1074 int rc = kstrtoul(buf, 0, &swsusp_resume_block);
1075
1076 if (rc)
1077 return rc;
1078
1079 return n;
1080 }
1081
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25524 bytes --]
prev parent reply other threads:[~2018-03-28 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 20:58 Mario Limonciello
2018-03-27 20:58 ` [PATCH v2 2/2] power/hibernate: Change message when writing to /sys/power/resume Mario Limonciello
2018-03-28 14:01 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803282121.2P3DkXpO%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®