From: Herbert Xu <herbert@gondor.apana.org.au>
To: NeilBrown <neilb@suse.com>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found.
Date: Thu, 29 Mar 2018 13:40:38 +0800 [thread overview]
Message-ID: <20180329054038.GB21028@gondor.apana.org.au> (raw)
In-Reply-To: <152228634995.16370.12793320017578882447.stgit@noble>
On Thu, Mar 29, 2018 at 12:19:09PM +1100, NeilBrown wrote:
> When rhltable_insert() finds an entry with the same key,
> it splices the new entry at the start of a list of entries with the
> same key.
> It stores the address of the new object in *pprev, but in general this
> is *not* the location where the match was found (though in a common
> case where the hash chain has one element, it will be).
> To fix this, pprev should be updated every time we find an object that
> doesn't match.
>
> This patch changes the behaviour for non-slow insertion in that now
> insertion happens at the end of a chain rather than at the head.
> I don't think this is an important change.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
Thanks. But Paul Blakey beat you to it :)
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=d3dcf8eb615537526bd42ff27a081d46d337816e
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-03-29 5:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 1:19 [PATCH 0/2] rhashtable_walk fixes NeilBrown
2018-03-29 1:19 ` [PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found NeilBrown
2018-03-29 5:40 ` Herbert Xu [this message]
2018-03-29 1:19 ` [PATCH 2/2] rhashtable: improve rhashtable_walk stability when stop/start used NeilBrown
2018-03-29 5:50 ` Herbert Xu
2018-03-30 14:18 ` [PATCH 0/2] rhashtable_walk fixes David Miller
2018-04-03 2:23 ` NeilBrown
2018-04-03 2:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329054038.GB21028@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®