From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Michael Thayer <michael.thayer@oracle.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] virt: vbox: Log an error whenwe fail to get the host version
Date: Thu, 29 Mar 2018 13:21:16 +0200 [thread overview]
Message-ID: <20180329112116.26488-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20180329112116.26488-1-hdegoede@redhat.com>
This was the only error path during probe without a message being logged
about what went wrong, this fixes this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/virt/vboxguest/vboxguest_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
index 7411a535fda2..2f3856a95856 100644
--- a/drivers/virt/vboxguest/vboxguest_core.c
+++ b/drivers/virt/vboxguest/vboxguest_core.c
@@ -727,8 +727,10 @@ static int vbg_query_host_version(struct vbg_dev *gdev)
rc = vbg_req_perform(gdev, req);
ret = vbg_status_code_to_errno(rc);
- if (ret)
+ if (ret) {
+ vbg_err("%s error: %d\n", __func__, rc);
goto out;
+ }
snprintf(gdev->host_version, sizeof(gdev->host_version), "%u.%u.%ur%u",
req->major, req->minor, req->build, req->revision);
--
2.17.0.rc1
next prev parent reply other threads:[~2018-03-29 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 11:21 [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function Hans de Goede
2018-03-29 11:21 ` [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory Hans de Goede
2018-03-29 11:57 ` Greg Kroah-Hartman
2018-03-29 11:58 ` Greg Kroah-Hartman
2018-03-29 13:42 ` Hans de Goede
2018-03-29 16:39 ` Greg Kroah-Hartman
2018-04-03 13:20 ` Hans de Goede
2018-03-29 11:21 ` Hans de Goede [this message]
2018-03-29 11:55 ` [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function Greg Kroah-Hartman
2018-03-29 13:12 ` Hans de Goede
2018-03-29 11:56 ` Greg Kroah-Hartman
2018-03-29 13:16 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329112116.26488-3-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®