From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbeC2MKn (ORCPT ); Thu, 29 Mar 2018 08:10:43 -0400 Received: from merlin.infradead.org ([205.233.59.134]:34512 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbeC2MKm (ORCPT ); Thu, 29 Mar 2018 08:10:42 -0400 Date: Thu, 29 Mar 2018 14:10:36 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, Will Deacon , Ingo Molnar Subject: Re: [PATCH v2] perf, pt, coresight: Clean up address filter structure Message-ID: <20180329121036.GZ4043@hirez.programming.kicks-ass.net> References: <20180329120648.11902-1-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180329120648.11902-1-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 29, 2018 at 03:06:48PM +0300, Alexander Shishkin wrote: > This is a cosmetic patch that deals with the address filter structure's > ambiguous fields 'filter' and 'range'. The former stands to mean that the > filter's *action* should be to filter the traces to its address range if > it's set or stop tracing if it's unset. This is confusing and hard on the > eyes, so this patch replaces it with 'action' enum. The 'range' field is > completely redundant (meaning that the filter is an address range as > opposed to a single address trigger), as we can use zero size to mean the > same thing. > > Signed-off-by: Alexander Shishkin > Acked-by: Mathieu Poirier Acked-by: Peter Zijlstra (Intel) Ingo, can you merge this?