From: Steven Rostedt <rostedt@goodmis.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] trace: Default to using trace_global_clock if sched_clock is unstable
Date: Fri, 30 Mar 2018 10:37:38 -0400 [thread overview]
Message-ID: <20180330103738.7f8a959b@gandalf.local.home> (raw)
In-Reply-To: <152241887306.28244.3237898674442763768@mail.alporthouse.com>
On Fri, 30 Mar 2018 15:07:53 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Sure, I was mainly floating the idea of trying to pick sensible
> defaults. Unstable clocks are quite rare nowadays, the ones we have in
> the lab are a pair of Core2 Duo.
I still have a box too ;-)
I'm not so against having global_clock become default if the TSC is
unstable. But there needs to be a printk warning (not a WARN, but
something like:
Warning: TSC unstable, switching tracing_clock default to "global"
If you want to keep local, then add "trace_clock=local" on the
kernel command line.
-- Steve
prev parent reply other threads:[~2018-03-30 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 22:25 Chris Wilson
2018-03-30 13:48 ` Steven Rostedt
[not found] ` <152241887306.28244.3237898674442763768@mail.alporthouse.com>
2018-03-30 14:37 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330103738.7f8a959b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®