From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart.VanAssche@wdc.com, pmladek@suse.com,
sergey.senozhatsky.work@gmail.com, tj@kernel.org,
jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn,
Tan Hu <tan.hu@zte.com.cn>
Subject: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk
Date: Mon, 2 Apr 2018 11:10:32 +0900 [thread overview]
Message-ID: <20180402021032.GE3795@jagdpanzerIV> (raw)
In-Reply-To: <1522634332-151328-1-git-send-email-wen.yang99@zte.com.cn>
Hello,
On (04/02/18 09:58), Wen Yang wrote:
> There would be so many same lines printed by frequent printk if one
> disk went wrong, like,
> [ 546.185242] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185258] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185280] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185307] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185334] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185364] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185390] sd 0:1:0:0: rejecting I/O to offline device
> [ 546.185410] sd 0:1:0:0: rejecting I/O to offline device
> For slow serial console, the frequent printk may be blocked for a
> long time, and if any spin_lock has been acquired before the printk
> like in scsi_request_fn, watchdog could be triggered.
Did you test the patch? Rate limiting does not completely remove
printk calls. printk is still there, in a loop under spin_lock.
A big enough I/O request queue can cause the same lockup problems.
-ss
next prev parent reply other threads:[~2018-04-02 2:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 1:58 Wen Yang
2018-04-02 2:10 ` Sergey Senozhatsky [this message]
[not found] ` <201804031419435288297@zte.com.cn>
2018-04-06 8:30 ` 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk Petr Mladek
2018-04-06 8:49 ` Petr Mladek
[not found] ` <201804091013439214247@zte.com.cn>
2018-04-09 8:59 ` 答复: Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited tothrottlefrequent printk Petr Mladek
2018-04-02 2:37 ` [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk Jason Yan
[not found] ` <201804021314481872986@zte.com.cn>
2018-04-02 5:29 ` 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk Sergey Senozhatsky
2018-04-02 6:07 ` Jason Yan
2018-04-02 6:06 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402021032.GE3795@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=Bart.VanAssche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pmladek@suse.com \
--cc=tan.hu@zte.com.cn \
--cc=tj@kernel.org \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®