From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Zhang Rui <rui.zhang@intel.com>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, edubezval@gmail.com
Subject: Re: [PATCH] time: export nsec_to_clock_t
Date: Mon, 2 Apr 2018 15:55:50 +0530 [thread overview]
Message-ID: <20180402102550.GE3572@vireshk-i7> (raw)
In-Reply-To: <alpine.DEB.2.21.1803292108350.1486@nanos.tec.linutronix.de>
On 29-03-18, 21:11, Thomas Gleixner wrote:
> On Thu, 29 Mar 2018, Zhang Rui wrote:
> > On 三, 2018-03-28 at 16:11 +0200, Arnd Bergmann wrote:
> > > nsec_to_clock_t was traditionally used only in the core kernel, now
> > > we
> > > have a sysfs file that needs it from a loadable module, causing a
> > > link-time error:
> > >
> > > ERROR: "nsec_to_clock_t" [drivers/thermal/thermal_sys.ko] undefined!
> > >
> > > This exports the function the same way that we do for related
> > > interfaces.
> > >
> > > Fixes: 96cea33badc5 ("thermal: Add cooling device's statistics in
> > > sysfs")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Thanks for the fix.
> > can I take this patch through thermal tree?
>
> Well, the question is what's the point of that?
>
> Why does a new interface expose time in state in clock_t instead in normal
> time units, e.g. nsec/usec/msec ?
The initial patch was displaying the values in msec, but eduardo asked the units
to be consistent with how cpufreq shows it, i.e. clock_t.
https://lkml.kernel.org/r/20180112174606.GA11076@localhost.localdomain
Anyway I will resend the patch and move back to msec. Thanks.
--
viresh
prev parent reply other threads:[~2018-04-02 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 14:11 Arnd Bergmann
2018-03-29 14:58 ` Zhang Rui
2018-03-29 19:11 ` Thomas Gleixner
2018-04-02 10:25 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402102550.GE3572@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=edubezval@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®