From: Keith Busch <keith.busch@intel.com>
To: Rodrigo Rosatti Galvao <rosattig@linux.vnet.ibm.com>
Cc: chaitany kulkarni <ckulkarnilinux@gmail.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
hch@lst.de, Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function
Date: Mon, 2 Apr 2018 08:21:42 -0600 [thread overview]
Message-ID: <20180402142141.GC28945@localhost.localdomain> (raw)
In-Reply-To: <8a3d1471-571d-3352-1414-bf2051e2ebb9@linux.vnet.ibm.com>
On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote:
> One thing that I just forgot to explain previously, but I think its
> relevant:
>
> 1. The command is failing with 4k logical block size, but works with 512B
>
> 2. With the patch, the command is working for both 512B and 4K.
While you're not getting errors with your patch, you're not zeroing out
the requested blocks, so that's a data corruption.
The issue is the +1 is in the wrong place. It needs to be added to the
native format prior to converting it to a 512b sector count. Do you want
to resend with that change?
next prev parent reply other threads:[~2018-04-02 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 21:18 Rodrigo R. Galvao
2018-03-30 21:24 ` Keith Busch
2018-03-30 21:48 ` Rodrigo Rosatti Galvão
2018-04-02 8:03 ` chaitany kulkarni
2018-04-02 13:47 ` Rodrigo Rosatti Galvao
2018-04-02 14:21 ` Keith Busch [this message]
2018-04-02 14:50 ` Rodrigo Rosatti Galvao
2018-04-02 13:47 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402142141.GC28945@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=ckulkarnilinux@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rosattig@linux.vnet.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®