From: Peter Zijlstra <peterz@infradead.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Ingo Molnar <mingo@kernel.org>,
Norbert Manthey <nmanthey@amazon.de>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64
Date: Tue, 3 Apr 2018 09:37:06 +0200 [thread overview]
Message-ID: <20180403073706.GV4082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180402232448.fbop7k5xicblski5@agluck-desk>
On Mon, Apr 02, 2018 at 04:24:49PM -0700, Luck, Tony wrote:
> v4.16 boots cleanly. But with the first bunch of merges
> (Linus HEAD = 46e0d28bdb8e6d00e27a0fe9e1d15df6098f0ffb)
> I see a bunch of:
>
> ia64_handle_unaligned: 4863 callbacks suppressed
> kernel unaligned access to 0xe00000031660fd74, ip=0xa0000001000f23e0
> kernel unaligned access to 0xe00000033bdffbcc, ip=0xa0000001000f2370
> kernel unaligned access to 0xe00000031660fd74, ip=0xa0000001000f23e0
> kernel unaligned access to 0xe00000033bdffbcc, ip=0xa0000001000f2370
> kernel unaligned access to 0xe00000031660fd74, ip=0xa0000001000f23e0
>
> The addresses are all 4-byte, but not 8-byte aligned.
>
> Any guesses before I start to bisect?
That doesn't sound good. The only guess I have at this moment is you
accidentially enabled RANDSTRUCT_PLUGIN and that messes things up.
struct task_struct whould be at least L1_CACHE_BYTES aligned, and C
otherwise makes it fairly hard to cause unaligned accesses. Packed
structures and/or casting are required, and I don't think we added
anything dodgy like that here.
next prev parent reply other threads:[~2018-04-03 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 23:24 Luck, Tony
2018-04-02 23:39 ` Luck, Tony
2018-04-03 7:37 ` Peter Zijlstra [this message]
2018-04-03 18:58 ` Luck, Tony
2018-04-04 0:04 ` Luck, Tony
2018-04-04 7:25 ` Peter Zijlstra
2018-04-04 16:38 ` Luck, Tony
2018-04-04 16:53 ` Peter Zijlstra
2018-04-05 8:05 ` Peter Zijlstra
2018-04-05 8:56 ` Ingo Molnar
2018-04-05 9:18 ` [tip:sched/urgent] sched/core: Force proper alignment of 'struct util_est' tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403073706.GV4082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=nmanthey@amazon.de \
--cc=patrick.bellasi@arm.com \
--cc=tony.luck@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome