From: David Miller <davem@davemloft.net>
To: agraf@suse.de
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Nisar.Sayed@microchip.com,
Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com,
tbogendoerfer@suse.de, phil@raspberrypi.org, andrew@lunn.ch,
RaghuramChary.Jallipalli@microchip.com
Subject: Re: [PATCH v2] lan78xx: Connect phy early
Date: Wed, 04 Apr 2018 11:41:56 -0400 (EDT) [thread overview]
Message-ID: <20180404.114156.2277005234997416804.davem@davemloft.net> (raw)
In-Reply-To: <20180403221935.51099-1-agraf@suse.de>
From: Alexander Graf <agraf@suse.de>
Date: Wed, 4 Apr 2018 00:19:35 +0200
> When using wicked with a lan78xx device attached to the system, we
> end up with ethtool commands issued on the device before an ifup
> got issued. That lead to the following crash:
>
...
> The culprit is quite simple: The driver tries to access the phy left and right,
> but only actually has a working reference to it when the device is up.
>
> The fix thus is quite simple too: Get a reference to the phy on probe already
> and keep it even when the device is going down.
>
> With this patch applied, I can successfully run wicked on my system and bring
> the interface up and down as many times as I want, without getting NULL pointer
> dereferences in between.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Applied, thank you.
prev parent reply other threads:[~2018-04-04 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 22:19 Alexander Graf
2018-04-04 15:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404.114156.2277005234997416804.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Nisar.Sayed@microchip.com \
--cc=RaghuramChary.Jallipalli@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=agraf@suse.de \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@raspberrypi.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®