From: Peter Zijlstra <peterz@infradead.org>
To: James Y Knight <jyknight@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
gregkh@linuxfoundation.org,
Nick Desaulniers <ndesaulniers@google.com>,
mka@chromium.org, Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tglx@linutronix.de, Andrew Morton <akpm@linux-foundation.org>,
Chandler Carruth <chandlerc@google.com>,
Stephen Hines <srhines@google.com>,
Kees Cook <keescook@google.com>,
groeck@chromium.org, Greg Hackmann <ghackmann@google.com>
Subject: Re: [GIT PULL] x86/build changes for v4.17
Date: Thu, 5 Apr 2018 09:08:10 +0200 [thread overview]
Message-ID: <20180405070810.GM4043@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAA2zVHqMS7HQggLnhQc9qjUhnD5MQXcyXkVnCQ0BoKqC8i3vgw@mail.gmail.com>
On Wed, Apr 04, 2018 at 10:21:05PM +0000, James Y Knight wrote:
> But allowing random pointer arithmetic, and pointer arithmetic wraparound,
> is still different than asserting that an object _field access_ can
> overflow. Clang does not believe that can happen -- it assumes that an
> object will still be contiguous. And that's why the llist stuff used to be
> broken, before it was corrected to do simply do math on a uintptr_t (which
> is a nice and simple and sane fix!).
That 'fix' wasn't anything simple, I recently ran into that
member_address_is_nonnull() trainwreck and had to think real hard wtf it
was about.
next prev parent reply other threads:[~2018-04-05 7:08 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 9:50 Ingo Molnar
2018-04-02 21:44 ` Linus Torvalds
2018-04-02 22:38 ` Matthias Kaehlcke
2018-04-03 1:26 ` Matthias Kaehlcke
2018-04-03 8:59 ` Peter Zijlstra
2018-04-03 9:51 ` Ingo Molnar
2018-04-03 12:09 ` Peter Zijlstra
2018-04-03 18:06 ` Matthias Kaehlcke
2018-04-03 21:58 ` Nick Desaulniers
2018-04-04 9:19 ` Peter Zijlstra
2018-04-04 9:38 ` Greg KH
2018-04-04 16:49 ` Nick Desaulniers
2018-04-04 17:13 ` Linus Torvalds
2018-04-04 17:46 ` Nick Desaulniers
2018-04-04 23:10 ` Nick Desaulniers
2018-04-04 16:53 ` Nick Desaulniers
2018-04-04 16:59 ` Greg KH
2018-04-04 19:26 ` James Y Knight
2018-04-04 19:42 ` Linus Torvalds
2018-04-04 22:21 ` James Y Knight
2018-04-04 22:29 ` Linus Torvalds
2018-04-05 7:08 ` Peter Zijlstra [this message]
2018-04-05 16:21 ` James Y Knight
2018-04-04 19:32 ` Josh Poimboeuf
2018-06-07 19:23 ` Nick Desaulniers
2018-06-07 20:11 ` Greg KH
2018-04-04 9:30 ` Peter Zijlstra
2018-04-04 19:17 ` Matthias Kaehlcke
2018-04-04 20:33 ` Arnd Bergmann
2018-04-04 20:58 ` Matthias Kaehlcke
2018-04-04 21:11 ` Arnd Bergmann
2018-04-04 21:46 ` Matthias Kaehlcke
2018-04-04 21:59 ` Linus Torvalds
2018-04-04 22:17 ` Matthias Kaehlcke
2018-04-04 22:39 ` Linus Torvalds
2018-04-04 23:31 ` Matthias Kaehlcke
2018-04-05 0:05 ` Linus Torvalds
2018-04-05 0:20 ` Kees Cook
2018-04-05 7:24 ` Peter Zijlstra
2018-04-05 8:04 ` Ingo Molnar
2018-04-05 8:24 ` Peter Zijlstra
2018-04-05 16:43 ` Linus Torvalds
2018-04-05 7:20 ` Peter Zijlstra
2018-04-05 17:46 ` James Y Knight
2018-04-05 18:06 ` Linus Torvalds
2018-04-05 20:51 ` James Y Knight
2018-04-05 21:13 ` Linus Torvalds
2018-04-05 22:51 ` James Y Knight
2018-04-06 2:02 ` Linus Torvalds
2018-04-05 17:47 ` James Y Knight
2018-04-04 23:04 ` Nick Desaulniers
2018-04-03 17:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405070810.GM4043@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chandlerc@google.com \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jyknight@google.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=srhines@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome