From: Andrew Morton <akpm@linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Huang Ying <ying.huang@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH v2 0/3] mm/get_user_pages_fast fixes, cleanups
Date: Fri, 6 Apr 2018 13:08:02 -0700 [thread overview]
Message-ID: <20180406130802.d80742aeda85a595150b28cf@linux-foundation.org> (raw)
In-Reply-To: <1522962072-182137-1-git-send-email-mst@redhat.com>
On Fri, 6 Apr 2018 00:03:48 +0300 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> Turns out get_user_pages_fast and __get_user_pages_fast return different
> values on error when given a single page: __get_user_pages_fast returns
> 0. get_user_pages_fast returns either 0 or an error.
>
> Callers of get_user_pages_fast expect an error so fix it up to return an
> error consistently.
>
> Stress the difference between get_user_pages_fast and __get_user_pages_fast
> to make sure callers aren't confused.
>
A term which is missing from all these changelogs is "vhost" :(
This patchset fixes a user-affecting bug, does it not? If so, please
fully describe that bug so that we can decide which kernel version(s)
need the patchset.
And yes, this return value asymmetry is sad. Did you scope out what
would be needed to fix up the callers so we can avoid this?
next prev parent reply other threads:[~2018-04-06 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 21:03 Michael S. Tsirkin
2018-04-05 21:03 ` [PATCH v2 1/3] mm/gup_benchmark: handle gup failures Michael S. Tsirkin
2018-04-07 20:08 ` Linus Torvalds
2018-04-08 3:12 ` Michael S. Tsirkin
2018-04-10 0:38 ` Andrew Morton
2018-04-05 21:03 ` [PATCH v2 2/3] gup: return -EFAULT on access_ok failure Michael S. Tsirkin
2018-04-05 21:03 ` [PATCH v2 3/3] mm/gup: document return value Michael S. Tsirkin
2018-04-06 20:08 ` Andrew Morton [this message]
2018-04-08 3:08 ` [PATCH v2 0/3] mm/get_user_pages_fast fixes, cleanups Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406130802.d80742aeda85a595150b28cf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=peterz@infradead.org \
--cc=regressions@leemhuis.info \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®