From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbeDFRIy (ORCPT ); Fri, 6 Apr 2018 13:08:54 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:39235 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbeDFRIx (ORCPT ); Fri, 6 Apr 2018 13:08:53 -0400 X-Google-Smtp-Source: AIpwx4/ukcEJz59X3oyfMMvka9ud+ZpYif1MW0MjbNCP8ft1EbNLEk14xNKm0iGEgdJSIDuJyvbQ6A== From: Esben Haabendal To: netdev@vger.kernel.org Cc: andrew@lunn.ch, richardcochran@gmail.com, f.fainelli@gmail.com, linux-kernel@vger.kernel.org, Esben Haabendal Subject: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset Date: Fri, 6 Apr 2018 19:08:44 +0200 Message-Id: <20180406170844.4248-1-esben.haabendal@gmail.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180406140540.13511-1-esben.haabendal@gmail.com> References: <20180406140540.13511-1-esben.haabendal@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Esben Haabendal Signed-off-by: Esben Haabendal --- drivers/net/phy/dp83640.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 654f42d00092..a6c87793d899 100644 --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -1207,6 +1207,23 @@ static void dp83640_remove(struct phy_device *phydev) kfree(dp83640); } +static int dp83640_soft_reset(struct phy_device *phydev) +{ + int ret; + + ret = genphy_soft_reset(phydev); + if (ret < 0) + return ret; + + /* From DP83640 datasheet: "Software driver code must wait 3 us + * following a software reset before allowing further serial MII + * operations with the DP83640." + */ + udelay(10); /* Taking udelay inaccuracy into account */ + + return 0; +} + static int dp83640_config_init(struct phy_device *phydev) { struct dp83640_private *dp83640 = phydev->priv; @@ -1501,6 +1518,7 @@ static struct phy_driver dp83640_driver = { .flags = PHY_HAS_INTERRUPT, .probe = dp83640_probe, .remove = dp83640_remove, + .soft_reset = dp83640_soft_reset, .config_init = dp83640_config_init, .ack_interrupt = dp83640_ack_interrupt, .config_intr = dp83640_config_intr, -- 2.16.3