From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] objtool: Support HOSTCFLAGS and HOSTLDFLAGS
Date: Fri, 6 Apr 2018 12:27:05 -0500 [thread overview]
Message-ID: <20180406172705.zvvmdf6d32jzj5v3@treble> (raw)
In-Reply-To: <20180329004805.7278-3-labbott@redhat.com>
On Wed, Mar 28, 2018 at 05:48:04PM -0700, Laura Abbott wrote:
> It may be useful to compile host programs with different flags (e.g.
> hardening). Ensure that objtool picks up the appropriate flags.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> tools/objtool/Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index e6acc281dd37..0ff3bcac1ca9 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile
> @@ -31,8 +31,9 @@ INCLUDES := -I$(srctree)/tools/include \
> -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
> -I$(srctree)/tools/objtool/arch/$(ARCH)/include
> WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
> -CFLAGS += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
> -LDFLAGS += -lelf $(LIBSUBCMD)
> +CFLAGS += -Wall -Werror $(WARNINGS) $(HOSTCFLAGS) -fomit-frame-pointer -O2 -g \
> + $(INCLUDES)
HOSTCFLAGS already has '-Wall', '-fomit-frame-pointer', and '-O2', so we
can remove the setting of those in CFLAGS here.
--
Josh
next prev parent reply other threads:[~2018-04-06 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 0:48 [PATCH 0/3] HOSTCFLAGS and HOSTLDFLAGS from the environment Laura Abbott
2018-03-29 0:48 ` [PATCH 1/3] kbuild: Support HOSTLDFLAGS Laura Abbott
2018-04-05 5:13 ` Masahiro Yamada
2018-03-29 0:48 ` [PATCH 2/3] objtool: Support HOSTCFLAGS and HOSTLDFLAGS Laura Abbott
2018-04-05 4:42 ` Masahiro Yamada
2018-04-05 22:01 ` Laura Abbott
2018-04-06 17:27 ` Josh Poimboeuf [this message]
2018-03-29 0:48 ` [PATCH 3/3] kbuild: Allow passing additional " Laura Abbott
2018-04-05 4:59 ` Masahiro Yamada
2018-04-05 21:51 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406172705.zvvmdf6d32jzj5v3@treble \
--to=jpoimboe@redhat.com \
--cc=labbott@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®