From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+B3CzErg8y6MJ1AhkkxraoAgOp2c9aMzfjp28B7U94c/nsb3k6zttnrZNqnFNWu1KAGsMs ARC-Seal: i=1; a=rsa-sha256; t=1523208403; cv=none; d=google.com; s=arc-20160816; b=EdGaNcauTXHgDOaxFppmvjGZ88DNzZCXG8OJRLE5QVd94hQveceEbTlEQoAxqzy5cS 857JmzcIvQUOXh4kK7jorJJYcx20q8V1auZsl6lSyOUMp4wPhJ0zhm6M+odYhfgglq7L wbYVDPRBaqp1bXKdqUfmS13GVM3TSXi+/vnnKI5IdTGOeF2rSlr5RYrEHWWTQ8OGISB9 5sgWUYUQCykRxawRRFXMuRE4IvtxrhGKqL3WCzJRsQD7BtTN5A6ILnKXmYM5svzzZs0B Bs1tHCt2XP31C/NHXQsWlfQswU+QwOXipF/VI6xl8G8iD7PQ/59pW4RKg+uYWaBGhuUd f55A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=700JYmxYtbCOaqcyEG7Kju9jo/6qo67aVMvDFYJ3O4Q=; b=Buyl7M+tF19+ZlDB6yCakI/Au4e/urseYGCRD1SvU4CHKvOfTn58aFkR5+b8XwXDA+ OwozUczy02YmsTcfwmkfb/GsSYn8RwFAlb2Hk0nOktZZoG7rPyqJp1osfK1bloLRfb3y mh9NAUn5anPuE7ERMkdN0JAbSAUboWLSto2ZKducjaU1aOVdiaC5ej7x4eioiL7XPZiM CyJlAEhuw4IrxlgOLl0DcxRSSIPyQ3JnSzG0Y5igi6oEnTVU1M/TQbTtCCSNEE7Ro0a2 c11429Vh4JpD1CAcUW0xFEXjKwCKE0PmdwXEheWu/QbMockzVJ3hdm/Y9L5ldbbLinHc M7fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of hdegoede@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=hdegoede@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of hdegoede@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=hdegoede@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com From: Hans de Goede To: Darren Hart , Andy Shevchenko , Ard Biesheuvel , "Luis R . Rodriguez" , Greg Kroah-Hartman , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Jones , Dave Olsthoorn , Will Deacon , Andy Lutomirski , Matt Fleming , David Howells , Mimi Zohar , Josh Triplett , dmitry.torokhov@gmail.com, mfuzzey@parkeon.com, keescook@chromium.org, Kalle Valo , Arend Van Spriel , Linus Torvalds , nbroeking@me.com, bjorn.andersson@linaro.org, Torsten Duwe , x86@kernel.org, linux-efi@vger.kernel.org Subject: [PATCH v2 0/5] efi/firmware/platform-x86: Add EFI embedded fw support Date: Sun, 8 Apr 2018 19:26:31 +0200 Message-Id: <20180408172636.13926-1-hdegoede@redhat.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597199774524534426?= X-GMAIL-MSGID: =?utf-8?q?1597199774524534426?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi All, Here is v2 of my patch-set to add support for EFI embedded fw to the kernel. The 3 most prominent changes are: 1) Add documentation describing the EFI embedded firmware mechanism to: Documentation/driver-api/firmware/request_firmware.rst 2) Instead of having a single dmi_system_id array with its driver_data members pointing to efi_embedded_fw_desc structs, have the drivers which need EFI embedded-fw support export a dmi_system_id array and register that with the EFI embedded-fw code This series also includes the first driver to use this, in the form of the touchscreen_dmi code (formerly silead_dmi) from drivers/platfrom/x86 3) As discussed during the review of v1 we want to make the firmware_loader code fallback to EFI embedded-fw optional. Rather the adding yet another firmware_request_foo variant for this, with the risk of later also needing firmware_request_foo_nowait, etc. variants I've decided to make the code check if the device has a "efi-embedded-fw" device-property bool set. This also seemed better because the same driver may want to use the fallback on some systems, but not on others since e.g. not all (x86) systems with a silead touchscreen have their touchscreen firmware embedded in their EFI. Note that (as discussed) when the EFI fallback path is requested, the usermodehelper fallback path is skipped. Here is the full changelog of patch 2/5 which is where most of the changes are: Changes in v2: -Rebased on driver-core/driver-core-next -Add documentation describing the EFI embedded firmware mechanism to: Documentation/driver-api/firmware/request_firmware.rst -Add a new EFI_EMBEDDED_FIRMWARE Kconfig bool and only build the embedded fw support if this is set. This is an invisible option which should be selected by drivers which need this -Remove the efi_embedded_fw_desc and dmi_system_id-s for known devices from the efi-embedded-fw code, instead drivers using this are expected to export a dmi_system_id array, with each entries' driver_data pointing to a efi_embedded_fw_desc struct and register this with the efi-embedded-fw code -Use kmemdup to make a copy instead of efi_mem_reserve()-ing the firmware, this avoids us messing with the EFI memmap and avoids the need to make changes to efi_mem_desc_lookup() -Make the firmware-loader code only fallback to efi_get_embedded_fw() if the passed in device has the "efi-embedded-fw" device-property bool set -Skip usermodehelper fallback when "efi-embedded-firmware" device-property is set Patches 3-5 are new and implement using the EFI embedded-fw mechanism for Silead gslXXXX and Chipone icn8505 touchscreens on x86 devices. Regards, Hans