From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3836577-1523240866-2-1060443934694482973 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523240865; b=oWgCV+YFCB4FK2hX4EAOxnoDp+wCZ8ChmdpfpCNIwhZHCNCRaA EsYspf8pWtyE30v6kbyFUC4GhQsa865aP0PFNACjRC+VgwxyQvFbK/fU3GSlp+U9 VidruDyMyxSPm/52aei+tC0/etgVaCNbaMyoQ+04/1y5eQIXc32zGLIpoCXj0UhQ g8HylnH2P3YzmqLFZLpcLNU+1U9recKsDgxtF3O7sS4GPJCH/JLWm1Vhv6FqCL8w Pv1OOpDZBOrw+zOEXDfKyQI9iaY9hUQUZb19qCQh1YP5Gc/8Zn0EF935s0B6Yzzp aut2YY65hXCoUc41F/Kklu4+wtw7CC7Hc07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=fm2; t=1523240865; bh=1RfBXGib3k GAqXam8feZrqilK8UL0hdK2hbgcQ0IyLY=; b=uku7XqRfD9wIlt6OrTS8ycdtKh aiciq5077AhvgGa+IvJlERdE1XVrAE1nPd1H3AxP7uj10qN5W01KInoY5Ty3pk4k FG6OiMjylgFDFE6WA+WLxWfXZfglFbG2/793xVUPWlVz8t59QpAKBnqU8JdcDMN/ XhX7QhrqautSwsnkwStl+SWWgPncPq/ew/qyR96ewdyJD2KQQYMa8QWDggsllvnb 8DzOrfIXkDLBam2Mym02cHLQyGAQiFUCp2vYE/18/Qina54376zGi13P/7GLdFBn BOlPEnbmQYfBt0j0jtU8KpU//Cu7/8VxNpBxE5Dn9mzPY0q9N8vxFidCoA8Q== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=M2RO41o2 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=M2RO41o2 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfLrXD33tYOoQpYhVFAFTbRfLYDalzj1dHky2jXySsQVbI0dxUPOljVyaj2+uS8P+pEwJj+yOCNHp7/VnyRcgF8tTOafhdsqT7OpIYSG7Y13gUa97nVxi OJbXvqniHK1s+ULc4P/F5G0t90uoZvRk7ByVff8BA/thtmANj8Yo5IUUrhE4HNsaP1oseByxpfiHpnWFqqjo5+WfHjpS5fXYbq3yuuS5m0W/ThyiYWDPpfWJ X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=wRwT6uffUbIA:10 a=t_PdEiP4ckcA:10 a=mw6kJ3eo-EIA:10 a=8nJEP1OIZ-IA:10 a=xqWC_Br6kY4A:10 a=Kd1tUaAdevIA:10 a=Lf-vpJhqX20A:10 a=AGRr4plBAAAA:8 a=J1Y8HTJGAAAA:8 a=yMhMjlubAAAA:8 a=wSlJkV0XXiFc0MHYEzgA:9 a=wPNLvfGTeEIA:10 a=bOnWt3ThIoLzEnqt84vq:22 a=y1Q9-5lHfBjTkpIzbSAN:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbeDIC1N (ORCPT ); Sun, 8 Apr 2018 22:27:13 -0400 Received: from mail-dm3nam03on0110.outbound.protection.outlook.com ([104.47.41.110]:12595 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755909AbeDIA2p (ORCPT ); Sun, 8 Apr 2018 20:28:45 -0400 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Ganesh Goudar , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 090/293] cxgb4: fix a NULL dereference Thread-Topic: [PATCH AUTOSEL for 4.9 090/293] cxgb4: fix a NULL dereference Thread-Index: AQHTz5kQuZNnFpDaO0ya+YpBX9CSUA== Date: Mon, 9 Apr 2018 00:24:04 +0000 Message-ID: <20180409002239.163177-90-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0807;7:0AInsYfWZJdy8k2F3+0enRZhQLrQxnFNvOVYu/KgQBkjRkuwwLxqzALn8DFbHC0YKNuzbrE1k8k2PMCDdPSH8wsYxiwmEuYxy3bMDqtZCPxpg8Vss8b/UG5AhCfpjlyuee1GUUpWGu7VPxtY4IXMCu+2+n7yLg5VdV+2H8mimMja8paNwDJDNgEyjATO8ztqNpMnN2R6wtZHnUP9X53VlvoduP1hpJDWDCldbzc1w27R1EKEEI7O9oUXXdbP8V3Y;20:X661Tk57hZW2cdCwDkjuSVNc1Rbaa/EQ9/fyydlqsgOnmC7O29OPL2TvK6UbqCObG4GiL46kJMGGN0oqf47qGNkg6GnvjUnhtihW8YLdqAr2RmbbYgXjV8SyJuCoN8GUtG8l4Qe3oIXk88OLpzpCqfgNQm6HD4ZTt4+Bl5xt2vU= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: b09c6c0b-8f30-4d9b-58b6-08d59db0d5fa x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0807; x-ms-traffictypediagnostic: DM5PR2101MB0807: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB0807;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0807; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(39860400002)(396003)(366004)(376002)(346002)(199004)(189003)(14454004)(4326008)(54906003)(25786009)(53936002)(2900100001)(1076002)(3280700002)(6486002)(186003)(2616005)(68736007)(110136005)(11346002)(10090500001)(6116002)(107886003)(3846002)(36756003)(8676002)(72206003)(22452003)(66066001)(26005)(6512007)(478600001)(3660700001)(81156014)(86362001)(81166006)(86612001)(7736002)(305945005)(8936002)(10290500003)(6436002)(105586002)(6666003)(316002)(59450400001)(76176011)(5660300001)(476003)(106356001)(2906002)(6506007)(446003)(2501003)(99286004)(5250100002)(486006)(102836004)(97736004)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0807;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-microsoft-antispam-message-info: 4MbTe91sZcXnTXCxmOTOLfrdZSiiVXE0nx5nZ7qX6LcKaYe8GlgFp13pa/T9d8vXfsMVI5B+CzipeRCWWnHLqsfiFFi5EjvhtfCDVvEkoDAqpajjfGl3JQqyQHCRyz1kW89SsKXlgqGY2qpaAJ5/ZVxVsUqmB0ivChLWMmqQeP7+QBEJchOTnSLOAtf0UVPpvo/D0LeRd7BxEft//9eE2Jtjkpk+sdxyYRzqtBCYBNYtMMOkpGwnZyFLkCB+b5Wos0LpPhJ49TXTrUPse0pcyOfw2iYVUPo95QaUL7trHGypQjgxNnszzf4QFDDf2h0VYczTZWUEGSTClRDgyXvApqXpUZHs7fYqxQ09JPSx0kKqADTolT2nld3u//o3f4IF2heXeOe0bFOdXWKrrG5Z7ubIUZzdlZuuKDF5gGqG5H8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b09c6c0b-8f30-4d9b-58b6-08d59db0d5fa X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:24:04.6281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0807 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Ganesh Goudar [ Upstream commit d427caee5a3f04938f47bec6fdec97a52668ee53 ] Avoid NULL dereference in setup_sge_queues() when the adapter is in non offload mode. Fixes: 0fbc81b3ad51 ('chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dyn= amically for all cxgb4 ULD's') Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/= ethernet/chelsio/cxgb4/cxgb4_main.c index 0c2a32a305bc..7968bdb85bb1 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -853,9 +853,12 @@ static int setup_sge_queues(struct adapter *adap) { int err, i, j; struct sge *s =3D &adap->sge; - struct sge_uld_rxq_info *rxq_info =3D s->uld_rxq_info[CXGB4_ULD_RDMA]; + struct sge_uld_rxq_info *rxq_info =3D NULL; unsigned int cmplqid =3D 0; =20 + if (is_uld(adap)) + rxq_info =3D s->uld_rxq_info[CXGB4_ULD_RDMA]; + for_each_port(adap, i) { struct net_device *dev =3D adap->port[i]; struct port_info *pi =3D netdev_priv(dev); --=20 2.15.1