From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbeDIIdZ (ORCPT ); Mon, 9 Apr 2018 04:33:25 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51360 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbeDIIdW (ORCPT ); Mon, 9 Apr 2018 04:33:22 -0400 Date: Mon, 9 Apr 2018 10:32:48 +0200 From: Peter Zijlstra To: Stafford Horne Cc: LKML , Will Deacon , Jonas Bonn , Stefan Kristiansson , Masahiro Yamada , Thomas Gleixner , Jan Henrik Weinstock , Michael Ellerman , Nicolas Dichtel , openrisc@lists.librecores.org Subject: Re: [PATCH] openrisc: define mb() as its mandatory Message-ID: <20180409083248.GV4082@hirez.programming.kicks-ass.net> References: <20180406205852.14821-1-shorne@gmail.com> <20180407090905.GQ4082@hirez.programming.kicks-ass.net> <20180408000729.GM2836@lianli.shorne-pla.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180408000729.GM2836@lianli.shorne-pla.net> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 08, 2018 at 09:07:29AM +0900, Stafford Horne wrote: > On Sat, Apr 07, 2018 at 11:09:05AM +0200, Peter Zijlstra wrote: > > On Sat, Apr 07, 2018 at 05:58:49AM +0900, Stafford Horne wrote: > > > Following Peter Z's patch ("asm-generic: Disallow no-op mb() for SMP > > > systems") which makes mb() mandatory for SMP architectures we define it > > > as l.msync. On OpenRISC this will flush the current cores write buffer > > > and trigger remote cores to invalidate their caches of the written > > > memory. > > > > > > Signed-off-by: Stafford Horne > > > Link: https://lkml.org/lkml/2018/1/31/254 > > > Cc: Peter Zijlstra > > > Cc: Will Deacon > > > --- > > > > > > Notes: > > > - Sorry, its been a while since we discussed this patch is the parent to this > > > still going in Peter? > > > > Oops.. yes it should. It seems I also lost track of it. Thanks for the > > reminder! > > No Problem, > > If you think this patch makes sense I can just put it into my OpenRISC queue for > 4.17. I dont see any reason to wait for yours. Any thoughts? I'm fine with you taking the patch, but I just saw the build robot found two failure cases: PARISC and 32-bit SPARC. I send patches for both, if their respective maintainers agree you could do the lot.