From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close
Date: Mon, 9 Apr 2018 13:40:34 +0200 [thread overview]
Message-ID: <20180409114034.GW4082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180409104010.GA22993@redhat.com>
On Mon, Apr 09, 2018 at 12:40:10PM +0200, Oleg Nesterov wrote:
> But I still think that we should (try to) remove put_task_struct() from put_ctx().
>
> Quite possibly I missed something, but I think it only adds some confusion. Once
> again, even if ctx can't go away you can't use ctx->task without TASK_TOMBSTONE
> check, exactly because this task can exit. So why perf_event_context should add
> another reference?
Ah, I see what you mean. Yes that might be possible.
next prev parent reply other threads:[~2018-04-09 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 5:08 Prashant Bhole
2018-02-22 16:37 ` Oleg Nesterov
2018-02-22 17:04 ` Peter Zijlstra
2018-02-22 17:09 ` Peter Zijlstra
2018-02-22 17:40 ` Oleg Nesterov
2018-03-06 9:49 ` Prashant Bhole
2018-04-09 7:38 ` Peter Zijlstra
2018-04-09 10:00 ` Prashant Bhole
2018-04-09 10:40 ` Oleg Nesterov
2018-04-09 11:40 ` Peter Zijlstra [this message]
2018-02-22 17:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409114034.GW4082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome