From: Peter Zijlstra <peterz@infradead.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: linux-kernel@vger.kernel.org,
Quentin Perret <quentin.perret@arm.com>,
Thara Gopinath <thara.gopinath@linaro.org>,
linux-pm@vger.kernel.org,
Morten Rasmussen <morten.rasmussen@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Valentin Schneider <valentin.schneider@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Todd Kjos <tkjos@google.com>, Joel Fernandes <joelaf@google.com>,
Juri Lelli <juri.lelli@redhat.com>,
Steve Muckle <smuckle@google.com>,
Eduardo Valentin <edubezval@gmail.com>
Subject: Re: [RFC PATCH v2 5/6] sched/fair: Select an energy-efficient CPU on task wake-up
Date: Mon, 9 Apr 2018 18:30:29 +0200 [thread overview]
Message-ID: <20180409163029.GJ4064@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180406153607.17815-6-dietmar.eggemann@arm.com>
On Fri, Apr 06, 2018 at 04:36:06PM +0100, Dietmar Eggemann wrote:
> if (sd_flag & SD_BALANCE_WAKE) {
> record_wakee(p);
> + want_energy = wake_energy(p, prev_cpu);
> want_affine = !wake_wide(p) && !wake_cap(p, cpu, prev_cpu)
> - && cpumask_test_cpu(cpu, &p->cpus_allowed);
> + && cpumask_test_cpu(cpu, &p->cpus_allowed)
> + && !want_energy;
Could you please fix that and put the operators at the end of the
previous line?
next prev parent reply other threads:[~2018-04-09 16:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 15:36 [RFC PATCH v2 0/6] Energy Aware Scheduling Dietmar Eggemann
2018-04-06 15:36 ` [RFC PATCH v2 1/6] sched/fair: Create util_fits_capacity() Dietmar Eggemann
2018-04-12 7:02 ` Viresh Kumar
2018-04-12 8:20 ` Dietmar Eggemann
2018-04-06 15:36 ` [RFC PATCH v2 2/6] sched: Introduce energy models of CPUs Dietmar Eggemann
2018-04-10 11:54 ` Peter Zijlstra
2018-04-10 12:03 ` Dietmar Eggemann
2018-04-13 4:02 ` Viresh Kumar
2018-04-13 8:37 ` Quentin Perret
2018-04-06 15:36 ` [RFC PATCH v2 3/6] sched: Add over-utilization/tipping point indicator Dietmar Eggemann
2018-04-13 23:56 ` Joel Fernandes
2018-04-18 11:17 ` Quentin Perret
2018-04-20 8:13 ` Joel Fernandes
2018-04-20 8:14 ` Joel Fernandes
2018-04-20 8:31 ` Quentin Perret
2018-04-20 8:57 ` Juri Lelli
2018-04-17 14:25 ` Leo Yan
2018-04-17 17:39 ` Dietmar Eggemann
2018-04-18 0:18 ` Leo Yan
2018-04-06 15:36 ` [RFC PATCH v2 4/6] sched/fair: Introduce an energy estimation helper function Dietmar Eggemann
2018-04-10 12:51 ` Peter Zijlstra
2018-04-10 13:56 ` Quentin Perret
2018-04-10 14:08 ` Peter Zijlstra
2018-04-13 6:27 ` Viresh Kumar
2018-04-17 15:22 ` Leo Yan
2018-04-18 8:13 ` Quentin Perret
2018-04-18 9:19 ` Leo Yan
2018-04-18 11:06 ` Quentin Perret
2018-04-18 9:23 ` Leo Yan
2018-04-20 14:51 ` Quentin Perret
2018-04-18 12:15 ` Leo Yan
2018-04-20 14:42 ` Quentin Perret
2018-04-20 16:27 ` Leo Yan
2018-04-25 8:23 ` Quentin Perret
2018-04-06 15:36 ` [RFC PATCH v2 5/6] sched/fair: Select an energy-efficient CPU on task wake-up Dietmar Eggemann
2018-04-09 16:30 ` Peter Zijlstra [this message]
2018-04-09 16:43 ` Quentin Perret
2018-04-10 17:29 ` Peter Zijlstra
2018-04-10 18:14 ` Quentin Perret
2018-04-17 15:39 ` Leo Yan
2018-04-18 7:57 ` Quentin Perret
2018-04-06 15:36 ` [RFC PATCH v2 6/6] drivers: base: arch_topology.c: Enable EAS for arm/arm64 platforms Dietmar Eggemann
2018-04-17 12:50 ` [RFC PATCH v2 0/6] Energy Aware Scheduling Leo Yan
2018-04-17 17:22 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409163029.GJ4064@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=smuckle@google.com \
--cc=thara.gopinath@linaro.org \
--cc=tkjos@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome