mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Hartman <ghartman@google.com>
Cc: Alistair Strachan <astrachan@google.com>,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	arve@android.com, tkjos@android.com, maco@android.com,
	devel@driverdev.osuosl.org, kernel-team@android.com
Subject: Re: [PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.
Date: Wed, 11 Apr 2018 21:32:16 +0300	[thread overview]
Message-ID: <20180411183216.hn7l5djgrzezomtr@mwanda> (raw)
In-Reply-To: <CAOvepGkHgJwZs+LtLb+10yXUkLrRxazEJk3o2he-awhMV3WMMQ@mail.gmail.com>

On Wed, Apr 11, 2018 at 10:49:47AM -0700, Greg Hartman wrote:
> > +     /* Ensure that the offset is within shared memory */
> > +     if (((uint64_t)arg->offset) + region_p->region_begin_offset +
> > +         sizeof(uint32_t) > region_p->region_end_offset)
> 
> I'm not certain if I understand the overflow.
> 
> arg->offset, region_begin_offset, and region_end_offset are all uint32.
> 

Ah...  You're right.  I didn't read carefully.  Sorry for the noise.

regards,
dan carpenter

      reply	other threads:[~2018-04-11 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 19:06 Alistair Strachan
2018-04-11  8:05 ` Dan Carpenter
2018-04-11 17:49   ` Greg Hartman
2018-04-11 18:32     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180411183216.hn7l5djgrzezomtr@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=arve@android.com \
    --cc=astrachan@google.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ghartman@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®