From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1229063-1523545972-2-10498073784598446320 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523545972; b=w+hbaP+L0kU2XH6x0g+PaI4rkwM4xDdWUfKR6tad9o2I/pIeG0 YFxz/wnzhGzV88N7TO1VlWAE3muRggI+dpm+DHpRRhebcCyOIt//+LNA1NHT81bb 6umBy2Uy3+OXSsTCvIvE+xr2yNKR3tO1ipIK36lm1sRpKTL0ZTs/4F/vljDAAI7l /Je21gbckWqo1Z7JZQex4+4vWXcl6gJLlGi+6zJPMlAnNbJfKJYFNUBF8egZMDEi fQi70Zfrva19tf+9AOSwzl9RfQjCoHRv+YIto9iSy8C5V8pSbYimz/2uAGLmrtQd Fev8cmIe80iuFbAimDLmCMblJSy8LQISlumA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=fm2; t=1523545972; bh=KJwOI mIP//sFvPWUUCiQowEj6yIo1EyVRHl3R6Fi98A=; b=mC0FJ62h+9cox2clrYSIT wY0lEKclx/3qGkhoJEAsYVoSgA2bMCGxXtmkPETXiTZrDybgezTZ/BBf2oI+YQu5 kXhu3Dqhpz9wofHO/VN8H18EZlYO01ERFOokNyVRzdnrG+f+NOC+WpV5U7hMTKgX YWw1LEWSmVJCBYiy/DVVG6n1HU3f1elNyVLNg+GFOLz8LGXkChyJrcyK47El0hIr 9f6Jom4JVBhgH/s+RKurbWWKo0/9EjRT9VYE7w+3zQ+wsmeWzOGTlX+7vR8e/Si6 oHwSi1p9nVg2/i60KcBB4QPHgy0S2sFFB4MvpK6s2ZGZH96tAoWemFwBGYCowtG/ g== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=UYOy2hQJ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=UYOy2hQJ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfFv/jI0S/greT4DYLoC9FXQr+VtHR2xm7wz3t1b7G5kjbrQj8IcTazapyLtjqsZu4r4oECblAbB9mlorGtn4ONFS7cPajiRqyt+Mj1a+UAASDSJhevKE F0rk+d03ky4D73BSlVIFDiZKzRJp2x7ytp80G9z5My+UJ/plA2elsIzufxL/Crc89+jEuGN6urQsTy/jajU/SEYNKcLAHSccV1sMH6GPNlGgmwRuamcyJALV VWAJrMrIlXp1Io7pRGvpaA== X-CM-Analysis: v=2.3 cv=NPP7BXyg c=1 sm=1 tr=0 a=28bQ1EhdAjTzU1YDPmtEKw==:117 a=28bQ1EhdAjTzU1YDPmtEKw==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=-uNXE31MpBQA:10 a=jJxKW8Ag-pUA:10 a=DDOyTI_5AAAA:8 a=yWe31jnlt1L-RX9p1H8A:9 a=CjuIK1q_8ugA:10 a=pC-h2on8RWMA:10 a=_BcfOz0m4U4ohdxiHPKc:22 cc=dsc X-ME-CMScore: 0 X-ME-CMCategory: discussion X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Thu, 12 Apr 2018 18:12:29 +0300 From: Dan Carpenter To: Colin King Subject: Re: [PATCH][next] staging: ks7010: fix null pointer dereference on priv on error exit Message-ID: <20180412151229.7san3ynhl5lbqgs4@mwanda> References: <20180412145756.24949-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180412145756.24949-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8860 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=551 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804120151 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Sergio Paracuellos , Quytelda Kahja Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: This isn't right. It introduces a leak. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel