From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbeDMS3H (ORCPT ); Fri, 13 Apr 2018 14:29:07 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:47570 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbeDMS3G (ORCPT ); Fri, 13 Apr 2018 14:29:06 -0400 Date: Fri, 13 Apr 2018 11:29:04 -0700 From: Guenter Roeck To: Helge Deller Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Subject: Re: [PATCH] parisc: Switch to generic COMPAT_BINFMT_ELF Message-ID: <20180413182904.GA1722@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2018 at 09:09:53AM +0200, Helge Deller wrote: > Drop our own compat binfmt implementation in > arch/parisc/kernel/binfmt_elf32.c in favour of the generic > implementation with CONFIG_COMPAT_BINFMT_ELF. > > While cleaning up the dependencies, I noticed that ELF_PLATFORM was strangely > defined: On a 32-bit kernel, it was defined to "PARISC", while when running in > compat mode on a 64-bit kernel it was defined to "PARISC32". Since it doesn't > seem to be used in glibc yet, it's now defined in both cases to "PARISC". In > any case, it can be distinguished because it's either a 32-bit or a 64-bit ELF > file. > > Signed-off-by: Helge Deller This patch results in: Building parisc:a500_defconfig ... failed -------------- Error log: make[2]: *** No rule to make target 'arch/parisc/kernel/binfmt_elf32.o', needed by 'arch/parisc/kernel/built-in.a'. Stop. make[2]: *** Waiting for unfinished jobs.... make[1]: *** [arch/parisc/kernel] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [sub-make] Error 2 -------------- Building parisc:generic-64bit_defconfig ... failed -------------- Error log: make[2]: *** No rule to make target 'arch/parisc/kernel/binfmt_elf32.o', needed by 'arch/parisc/kernel/built-in.a'. Stop. Indeed, arch/parisc/kernel/binfmt_elf32.o is still listed in Makefile for 64-bit builds. $ git grep binfmt_elf32.o arch/parisc/ arch/parisc/kernel/Makefile:obj-$(CONFIG_64BIT) += binfmt_elf32.o sys_parisc32.o signal32.o Guenter