From: Khazhismel Kumykov <khazhy@google.com>
To: nborisov@suse.com, akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Khazhismel Kumykov <khazhy@google.com>,
David Rientjes <rientjes@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Goldwyn Rodrigues <rgoldwyn@suse.de>,
Jeff Mahoney <jeffm@suse.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] fs/dcache.c: re-add cond_resched() in shrink_dcache_parent()
Date: Fri, 13 Apr 2018 13:28:23 -0700 [thread overview]
Message-ID: <20180413202823.204377-1-khazhy@google.com> (raw)
In-Reply-To: <20180413181350.88831-1-khazhy@google.com>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
shrink_dcache_parent may spin waiting for a parallel shrink_dentry_list.
In this case we may have 0 dentries to dispose, so we will never
schedule out while waiting for the parallel shrink_dentry_list to
complete.
Tested that this fixes syzbot reports of stalls in shrink_dcache_parent()
Fixes: 32785c0539b7 ("fs/dcache.c: add cond_resched() in shrink_dentry_list()")
Reported-by: syzbot+ae80b790eb412884ca77@syzkaller.appspotmail.com
Cc: Nikolay Borisov <nborisov@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
fs/dcache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/dcache.c b/fs/dcache.c
index 591b34500e41..3507badeb60a 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1489,6 +1489,7 @@ void shrink_dcache_parent(struct dentry *parent)
break;
shrink_dentry_list(&data.dispose);
+ cond_resched();
}
}
EXPORT_SYMBOL(shrink_dcache_parent);
--
2.17.0.484.g0c8726318c-goog
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4843 bytes --]
next parent reply other threads:[~2018-04-13 20:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180413181350.88831-1-khazhy@google.com>
2018-04-13 20:28 ` Khazhismel Kumykov [this message]
2018-04-13 21:14 ` Andrew Morton
2018-04-14 7:00 ` Nikolay Borisov
2018-04-14 8:02 ` Al Viro
2018-04-14 16:36 ` Linus Torvalds
2018-04-14 20:58 ` Al Viro
2018-04-14 21:47 ` Linus Torvalds
2018-04-15 0:51 ` Al Viro
2018-04-15 2:39 ` Al Viro
2018-04-15 14:21 ` Al Viro
2018-04-15 18:34 ` Linus Torvalds
2018-04-15 20:40 ` Al Viro
2018-04-15 21:54 ` Al Viro
2018-04-15 22:34 ` Al Viro
2018-04-16 18:28 ` Khazhismel Kumykov
2018-04-13 21:15 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413202823.204377-1-khazhy@google.com \
--to=khazhy@google.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=jeffm@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=rgoldwyn@suse.de \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®