From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751224AbeDOHce (ORCPT ); Sun, 15 Apr 2018 03:32:34 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44592 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbeDOHcd (ORCPT ); Sun, 15 Apr 2018 03:32:33 -0400 Date: Sun, 15 Apr 2018 00:32:29 -0700 From: Christoph Hellwig To: Mark Brown Cc: Peter Rosin , linux-kernel@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag Message-ID: <20180415073229.GA19823@infradead.org> References: <20180412161601.GI9929@sirena.org.uk> <20180412211437.21599-1-peda@axentia.se> <20180412211437.21599-4-peda@axentia.se> <20180413111927.GC6854@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180413111927.GC6854@sirena.org.uk> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 12:19:27PM +0100, Mark Brown wrote: > On Thu, Apr 12, 2018 at 11:14:35PM +0200, Peter Rosin wrote: > > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > * Driver for the MAX9860 Mono Audio Voice Codec > > * > > Please don't mix C and C++ comments like this - it looks unintentional > and messy. Just convert the entire comment block to C++ so it's > consistent with itself. NAK - that is exactky the wrong way to go. Normal Linux comments are classi C-style comments and should remain so. SPDX tags use c++ comments exactly to be different and stick out. ---end quoted text---