From: David Miller <davem@davemloft.net>
To: rafalo@cadence.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Receive Side Coalescing for macb driver
Date: Mon, 16 Apr 2018 11:08:55 -0400 (EDT) [thread overview]
Message-ID: <20180416.110855.61732218036810337.davem@davemloft.net> (raw)
In-Reply-To: <1523739187-20077-1-git-send-email-rafalo@cadence.com>
From: Rafal Ozieblo <rafalo@cadence.com>
Date: Sat, 14 Apr 2018 21:53:07 +0100
> This patch series adds support for receive side coalescing
> for Cadence GEM driver. Receive segmentation coalescing
> is a mechanism to reduce CPU overhead. This is done by
> coalescing received TCP message segments together into
> a single large message. This means that when the message
> is complete the CPU only has to process the single header
> and act upon the one data payload.
You're going to have to think more deeply about enabling this
feature.
If you can't adjust the receive buffer offset, then the various
packet header fields will be unaligned.
On certain architectures this will result in unaligned traps
all over the networking stack as the packet is being processed.
So enabling this by default will hurt performance on such
systems a lot.
The whole "skb_reserve(skb, NET_IP_ALIGN)" is not just for fun,
it is absolutely essential.
next prev parent reply other threads:[~2018-04-16 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 20:53 Rafal Ozieblo
2018-04-14 20:53 ` [PATCH 1/3] net: macb: Add support for rsc capable hardware Rafal Ozieblo
2018-04-14 20:54 ` [PATCH 2/3] net: macb: Add support for header data spliting Rafal Ozieblo
2018-04-14 20:55 ` [PATCH 3/3] net: macb: Receive Side Coalescing (RSC) feature added Rafal Ozieblo
2018-04-16 15:08 ` David Miller [this message]
2018-04-17 8:59 ` [PATCH 0/3] Receive Side Coalescing for macb driver Rafal Ozieblo
2018-04-17 13:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416.110855.61732218036810337.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=rafalo@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®