From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbeDPHpk (ORCPT ); Mon, 16 Apr 2018 03:45:40 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33149 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeDPHpi (ORCPT ); Mon, 16 Apr 2018 03:45:38 -0400 X-Google-Smtp-Source: AIpwx48McBGIo6B9cFWUz0CR2AX+ndnsWdTxMBpsLAD0aLXJ1wDBPWiCS/WIUZr7PzJGS0xo+ASSQQ== Date: Mon, 16 Apr 2018 09:45:35 +0200 From: Daniel Vetter To: Julia Lawall Cc: Joel Stanley , linux-aspeed@lists.ozlabs.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Jeffery , kbuild-all@01.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm: fix drm-get-put.cocci warnings Message-ID: <20180416074535.GH31310@phenom.ffwll.local> Mail-Followup-To: Julia Lawall , Joel Stanley , linux-aspeed@lists.ozlabs.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Jeffery , kbuild-all@01.org, linux-arm-kernel@lists.infradead.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > From: Fengguang Wu > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > tree: https://github.com/shenki/linux drm-v1 This isn't an upstream tree (and the aspeed driver isn't in upstream afaict), so no need for spamming mailing lists I think. But thanks for doing all this, great motivation to put more of the drm refactorings into cocci files. Cheers, Daniel > head: 9680ed7979d5d403c6bde36271a048d62c048180 > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED > GFX > driver > > aspeed_gfx_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf > err_unload: > aspeed_gfx_unload(drm); > err_free: > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat > > drm_dev_unregister(drm); > aspeed_gfx_unload(drm); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return 0; > } > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch