From: Mark Brown <broonie@kernel.org>
To: Kirill Marinushkin <k.marinushkin@gmail.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Pan Xiuli <xiuli.pan@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 2/3] ASoC: topology: Add missing clock gating parameter when parsing hw_configs
Date: Mon, 16 Apr 2018 17:52:06 +0100 [thread overview]
Message-ID: <20180416165206.GE20726@sirena.org.uk> (raw)
In-Reply-To: <20180404041939.23317-3-k.marinushkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Wed, Apr 04, 2018 at 06:19:38AM +0200, Kirill Marinushkin wrote:
> + /* clock gating */
> + if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED)
> + link->dai_fmt |= SND_SOC_DAIFMT_GATED;
> + else if (hw_config->clock_gated ==
> + SND_SOC_TPLG_DAI_CLK_GATE_CONT)
> + link->dai_fmt |= SND_SOC_DAIFMT_CONT;
I'll apply this but the above would be better written as a switch
statement - could you please send an incremental patch changing it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-04-16 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 4:19 [PATCH v4 0/3] ASoC: topology: Improve hw_configs Kirill Marinushkin
2018-04-04 4:19 ` [PATCH v4 1/3] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() Kirill Marinushkin
2018-04-04 4:19 ` [PATCH v4 2/3] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-04-16 16:52 ` Mark Brown [this message]
2018-04-16 17:56 ` [PATCH] ASoC: topology: Modify clock gating parameter parsing to switch Kirill Marinushkin
2018-04-16 18:46 ` Applied "ASoC: topology: Modify clock gating parameter parsing to switch" to the asoc tree Mark Brown
2018-04-04 4:19 ` [PATCH v4 3/3] ASoC: topology: Add definitions for mclk_direction values Kirill Marinushkin
2018-04-16 17:15 ` Applied "ASoC: topology: Add definitions for mclk_direction values" to the asoc tree Mark Brown
2018-04-04 18:57 ` [alsa-devel] [PATCH v4 0/3] ASoC: topology: Improve hw_configs Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416165206.GE20726@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=k.marinushkin@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®