mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andres Rodriguez <andresx7@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: andresx7@gmail.com, gregkh@linuxfoundation.org,
	mcgrof@kernel.org, alexdeucher@gmail.com,
	ckoenig.leichtzumerken@gmail.com, kvalo@codeaurora.org,
	arend.vanspriel@broadcom.com
Subject: [PATCH 0/8] Loading optional firmware v2
Date: Mon, 16 Apr 2018 18:24:19 -0400	[thread overview]
Message-ID: <20180416222427.29683-1-andresx7@gmail.com> (raw)

Hey Everyone,

Thanks everyone for the feedback on the RFC:
https://lkml.org/lkml/2018/3/9/903

Seems like there is a general interest in this feature, so here
is a V2 of the proposal with the comments I received.

Please provide comments on the _nowait2() API. It is not my favorite,
but it seems like the ship on exposing fw_opts directly to the caller
has sailed. If anyone has a better suggestion let me know.

Also, if anyone has better suggestions for the fw_opt enum documentation
please let me know. I may have botched some of the details since I'm not
super familiar with them.

I've also included patches for the following consumer drivers:
   - amdgpu
   - ath10k
   - brcmfmac

Thanks again for your feedback.

Regards,
Andres


Andres Rodriguez (8):
  firmware: some documentation fixes
  firmware: wrap FW_OPT_* into an enum
  firmware: add kernel-doc for enum fw_opt
  firmware: add functions to load firmware without warnings v3
  firmware: print firmware name on fallback path
  drm/amdgpu: use firmware_request_nowarn to load firmware
  ath10k: use request_firmware_nowarn to load firmware
  brcmfmac: use request_firmware_nowait2 to load firmware without
    warnings

 .../driver-api/firmware/request_firmware.rst       | 29 ++++++-----
 drivers/base/firmware_loader/fallback.c            | 18 +++----
 drivers/base/firmware_loader/fallback.h            |  8 +--
 drivers/base/firmware_loader/firmware.h            | 28 ++++++++---
 drivers/base/firmware_loader/main.c                | 58 +++++++++++++++++++---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c         |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h          |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c            |  2 +-
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c                |  2 +-
 drivers/gpu/drm/amd/amdgpu/cik_sdma.c              |  2 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c              |  8 +--
 drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c              | 12 ++---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c              | 32 ++++++------
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c              | 12 ++---
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c              |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c              |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c              |  2 +-
 drivers/gpu/drm/amd/amdgpu/psp_v10_0.c             |  2 +-
 drivers/gpu/drm/amd/amdgpu/psp_v3_1.c              |  4 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c             |  2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c             |  2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c             |  2 +-
 drivers/gpu/drm/amd/amdgpu/si_dpm.c                |  2 +-
 drivers/net/wireless/ath/ath10k/core.c             |  2 +-
 .../broadcom/brcm80211/brcmfmac/firmware.c         |  7 +--
 include/linux/firmware.h                           |  6 +++
 29 files changed, 164 insertions(+), 94 deletions(-)

-- 
2.14.1

             reply	other threads:[~2018-04-16 22:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 22:24 Andres Rodriguez [this message]
2018-04-16 22:24 ` [PATCH 1/8] firmware: some documentation fixes Andres Rodriguez
2018-04-16 22:24 ` [PATCH 2/8] firmware: wrap FW_OPT_* into an enum Andres Rodriguez
2018-04-16 22:24 ` [PATCH 3/8] firmware: add kernel-doc for enum fw_opt Andres Rodriguez
2018-04-16 22:24 ` [PATCH 4/8] firmware: add functions to load firmware without warnings v3 Andres Rodriguez
2018-04-16 22:52   ` Randy Dunlap
2018-04-16 22:24 ` [PATCH 5/8] firmware: print firmware name on fallback path Andres Rodriguez
2018-04-16 22:24 ` [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware Andres Rodriguez
2018-04-17  8:48   ` Christian König
2018-04-17 15:07     ` Andres Rodriguez
2018-04-17 15:33       ` Christian König
2018-04-17 15:41         ` Andres Rodriguez
2018-04-17 15:52           ` Christian König
2018-04-17 16:41             ` Andres Rodriguez
2018-04-17 16:50               ` Andres Rodriguez
2018-04-16 22:24 ` [PATCH 7/8] ath10k: use request_firmware_nowarn " Andres Rodriguez
2018-04-16 22:24 ` [PATCH 8/8] brcmfmac: use request_firmware_nowait2 to load firmware without warnings Andres Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416222427.29683-1-andresx7@gmail.com \
    --to=andresx7@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®