From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
Dmitry Eremin <dmitry.eremin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
NeilBrown <neilb@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 18/25] staging: lustre: libcfs: clear up failure patch in cfs_cpt_*_print
Date: Tue, 17 Apr 2018 10:39:02 +0300 [thread overview]
Message-ID: <20180417073902.slxgixniiytw7guk@mwanda> (raw)
In-Reply-To: <1523851807-16573-19-git-send-email-jsimmons@infradead.org>
> -err:
> - if (rc < 0)
> - return rc;
> -
> return tmp - buf;
> +
> +err:
> + return -E2BIG;
We finally fixed this bug! Hooray! But it's like you guys are
deliberately writing in terrible style. You can just return directly
and then you would have avoided this bug altogether from square one!
People think that by adding little twists and moving code to the end
of the function the it will be less buggy. It's not true. It's like at
a hospital if they just swept the cockroaches under the bed, just
because it's at the end of the function where you can't see it or review
it doesn't mean it's not buggy.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-17 7:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 4:09 [PATCH 00/25] staging: lustre: libcfs: SMP rework James Simmons
2018-04-16 4:09 ` [PATCH 01/25] staging: lustre: libcfs: remove useless CPU partition code James Simmons
2018-04-16 13:42 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 02/25] staging: lustre: libcfs: rename variable i to cpu James Simmons
2018-04-16 4:09 ` [PATCH 03/25] staging: lustre: libcfs: implement cfs_cpt_cpumask for UMP case James Simmons
2018-04-16 13:51 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 04/25] staging: lustre: libcfs: replace MAX_NUMNODES with nr_node_ids James Simmons
2018-04-16 13:55 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 05/25] staging: lustre: libcfs: remove excess space James Simmons
2018-04-16 4:09 ` [PATCH 06/25] staging: lustre: libcfs: replace num_possible_cpus() with nr_cpu_ids James Simmons
2018-04-16 4:09 ` [PATCH 07/25] staging: lustre: libcfs: NUMA support James Simmons
2018-04-16 14:27 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 08/25] staging: lustre: libcfs: add cpu distance handling James Simmons
2018-04-16 14:45 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 09/25] staging: lustre: libcfs: use distance in cpu and node handling James Simmons
2018-04-16 4:09 ` [PATCH 10/25] staging: lustre: libcfs: provide debugfs files for distance handling James Simmons
2018-04-16 4:09 ` [PATCH 11/25] staging: lustre: libcfs: invert error handling for cfs_cpt_table_print James Simmons
2018-04-17 7:14 ` Dan Carpenter
2018-04-16 4:09 ` [PATCH 12/25] staging: lustre: libcfs: fix libcfs_cpu coding style James Simmons
2018-04-16 4:09 ` [PATCH 13/25] staging: lustre: libcfs: use int type for CPT identification James Simmons
2018-04-16 4:09 ` [PATCH 14/25] staging: lustre: libcfs: rename i to node for cfs_cpt_set_nodemask James Simmons
2018-04-16 4:09 ` [PATCH 15/25] staging: lustre: libcfs: rename i to cpu for cfs_cpt_bind James Simmons
2018-04-16 4:09 ` [PATCH 16/25] staging: lustre: libcfs: rename cpumask_var_t variables to *_mask James Simmons
2018-04-16 4:09 ` [PATCH 17/25] staging: lustre: libcfs: rename goto label in cfs_cpt_table_print James Simmons
2018-04-17 7:34 ` Dan Carpenter
2018-04-16 4:10 ` [PATCH 18/25] staging: lustre: libcfs: clear up failure patch in cfs_cpt_*_print James Simmons
2018-04-17 7:39 ` Dan Carpenter [this message]
2018-04-16 4:10 ` [PATCH 19/25] staging: lustre: libcfs: update debug messages James Simmons
2018-04-16 4:10 ` [PATCH 20/25] staging: lustre: libcfs: make tolerant to offline CPUs and empty NUMA nodes James Simmons
2018-04-16 4:10 ` [PATCH 21/25] staging: lustre: libcfs: report NUMA node instead of just node James Simmons
2018-04-16 4:10 ` [PATCH 22/25] staging: lustre: libcfs: update debug messages in CPT code James Simmons
2018-04-16 4:10 ` [PATCH 23/25] staging: lustre: libcfs: rework CPU pattern parsing code James Simmons
2018-04-16 4:10 ` [PATCH 24/25] staging: lustre: libcfs: change CPT estimate algorithm James Simmons
2018-04-16 4:10 ` [PATCH 25/25] staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code James Simmons
2018-04-23 12:58 ` [PATCH 00/25] staging: lustre: libcfs: SMP rework Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417073902.slxgixniiytw7guk@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=neilb@suse.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®