mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vicentiu Galanopulo <vicentiu.galanopulo@nxp.com>
To: andrew@lunn.ch, robh@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, mark.rutland@arm.com,
	davem@davemloft.net, marcel@holtmann.org,
	devicetree@vger.kernel.org
Cc: alexandru.marginean@nxp.com, madalin.bucur@nxp.com,
	vicentiu.galanopulo@nxp.com
Subject: [PATCH net-next 2/3] net: phy: Change the array size to 32 for device_ids
Date: Tue, 17 Apr 2018 04:02:32 -0500	[thread overview]
Message-ID: <20180417090233.21548-3-vicentiu.galanopulo@nxp.com> (raw)
In-Reply-To: <20180417090233.21548-1-vicentiu.galanopulo@nxp.com>

In the context of enabling the discovery of the PHYs
which have the C45 MDIO address space in a non-standard
address:  num_ids in get_phy_c45_ids, has the
value 8 (ARRAY_SIZE(c45_ids->device_ids)), but the
u32 *devs can store 32 devices in the bitfield.

If a device is stored in *devs, in bits 32 to 9
(bit counting in lookup loop starts from 1), it will
not be found.

Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@nxp.com>
---
 include/linux/phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index f0b5870..26aa320 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -360,7 +360,7 @@ enum phy_state {
  */
 struct phy_c45_device_ids {
 	u32 devices_in_package;
-	u32 device_ids[8];
+	u32 device_ids[32];
 };
 
 /* phy_device: An instance of a PHY
-- 
2.7.4

  parent reply	other threads:[~2018-04-17  9:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  9:02 [PATCH net-next 0/3] net: phy: Enable C45 vendor specific MDIO register addr space Vicentiu Galanopulo
2018-04-17  9:02 ` [PATCH net-next 1/3] net: phy: Add binding for vendor specific C45 MDIO address space Vicentiu Galanopulo
2018-04-17 12:53   ` Andrew Lunn
2018-04-17 18:18   ` Florian Fainelli
2018-04-17 18:27     ` Andrew Lunn
2018-04-17 18:29       ` Florian Fainelli
2018-04-24 13:14         ` Rob Herring
2018-04-17  9:02 ` Vicentiu Galanopulo [this message]
2018-04-17 12:54   ` [PATCH net-next 2/3] net: phy: Change the array size to 32 for device_ids Andrew Lunn
2018-04-17 18:18   ` Florian Fainelli
2018-04-17  9:02 ` [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space Vicentiu Galanopulo
2018-04-17 12:56   ` Andrew Lunn
2018-04-17 18:27   ` Florian Fainelli
2018-04-18  9:38     ` Vicenţiu Galanopulo
2018-04-18 12:27       ` Andrew Lunn
2018-04-25 22:46   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417090233.21548-3-vicentiu.galanopulo@nxp.com \
    --to=vicentiu.galanopulo@nxp.com \
    --cc=alexandru.marginean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®