From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
Sandipan Das <sandipan@linux.vnet.ibm.com>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org,
naveen.n.rao@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com,
maynard@us.ibm.com
Subject: Re: [PATCH v2 0/3] perf: Fixes for callchain ip handling on powerpc
Date: Wed, 18 Apr 2018 14:53:43 -0300 [thread overview]
Message-ID: <20180418175343.GB22762@kernel.org> (raw)
In-Reply-To: <20180418105900.5899-1-sandipan@linux.vnet.ibm.com>
Em Wed, Apr 18, 2018 at 04:28:57PM +0530, Sandipan Das escreveu:
> The first patch fixes the callchain ip filtering mechanism for powerpc
> from skipping entries in case the LR value is still valid and yet to
> be written to the stack frame. This was previously posted as an RFC
> here: https://lkml.org/lkml/2018/4/4/633
>
> The second patch fixes a crash caused by attempting to access an empty
> callchain.
>
> The third patch fixes a shell test which used to fail on powerpc as
> the back trace from perf output did not match the expected pattern.
> Also, because of the issue described in the first patch, some entries
> from the callchain were incorrectly skipped. So, this has also been
> readjusted to work with the fix in the first patch.
> v2:
> - Consider case when return address is in R0 as pointed out by Ravi.
> - Add another patch to fix crash when callchain is empty.
Ravi, can you please take a look at these? The other two patches too,
please?
- Arnaldo
next prev parent reply other threads:[~2018-04-18 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 10:58 Sandipan Das
2018-04-18 10:58 ` [PATCH v2 1/3] perf tools powerpc: Fix callchain ip filtering Sandipan Das
2018-04-18 10:58 ` [PATCH v2 2/3] perf tools powerpc: Fix crash if callchain is empty Sandipan Das
2018-04-18 10:59 ` [PATCH v2 3/3] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 Sandipan Das
2018-04-18 17:53 ` Arnaldo Carvalho de Melo [this message]
2018-04-19 6:01 ` [PATCH v2 0/3] perf: Fixes for callchain ip handling on powerpc Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418175343.GB22762@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maynard@us.ibm.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=sandipan@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome